honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: fix aio size tracking, we need to use node_modules local to aio (#23328) 

This fixes an issue introduced by 4f0cae0676 which removed firebase from the root node_modules.

PR Close #23328
This commit is contained in:
Igor Minar 2018-04-11 16:01:53 -07:00
parent 37d2cb4553
commit 7e8cee6b61
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
aio/scripts/payload.sh
View File

@ -8,5 +8,8 @@ readonly parentDir=$(dirname $thisDir)
# Track payload size functions # Track payload size functions
source ../scripts/ci/payload-size.sh source ../scripts/ci/payload-size.sh
# Provide node_modules from aio
NODE_MODULES_BIN=$PROJECT_ROOT/aio/node_modules/.bin/
trackPayloadSize "aio" "dist/*.js" true true "${thisDir}/_payload-limits.json" trackPayloadSize "aio" "dist/*.js" true true "${thisDir}/_payload-limits.json"

3
scripts/ci/payload-size.sh
View File

@ -3,6 +3,7 @@
set -eu -o pipefail set -eu -o pipefail
readonly PROJECT_NAME="angular-payload-size" readonly PROJECT_NAME="angular-payload-size"
NODE_MODULES_BIN=$PROJECT_ROOT/node_modules/.bin/
# Calculate the size of target file uncompressed size, gzip7 size, gzip9 size # Calculate the size of target file uncompressed size, gzip7 size, gzip9 size
# Write to global variable $payloadData, $filename # Write to global variable $payloadData, $filename
@ -88,7 +89,7 @@ uploadData() {
# WARNING: FIREBASE_TOKEN should NOT be printed. # WARNING: FIREBASE_TOKEN should NOT be printed.
set +x set +x
$PROJECT_ROOT/node_modules/.bin/firebase database:update --data "$payloadData" --project $PROJECT_NAME --confirm --token "$ANGULAR_PAYLOAD_FIREBASE_TOKEN" $dbPath $NODE_MODULES_BIN/firebase database:update --data "$payloadData" --project $PROJECT_NAME --confirm --token "$ANGULAR_PAYLOAD_FIREBASE_TOKEN" $dbPath
fi fi
} }