parent
c130812afe
commit
7eadf2e6da
|
@ -69,7 +69,7 @@ More info on the possible HTTP status codes and their meaning can be found
|
||||||
|
|
||||||
|
|
||||||
### Updating PR visibility
|
### Updating PR visibility
|
||||||
- nginx receives a natification that a PR has been updated and passes it through to the
|
- nginx receives a notification that a PR has been updated and passes it through to the
|
||||||
preview-server. This could, for example, be sent by a GitHub webhook every time a PR's labels
|
preview-server. This could, for example, be sent by a GitHub webhook every time a PR's labels
|
||||||
change.
|
change.
|
||||||
E.g.: `ngbuilds.io/pr-updated` (payload: `{"number":<PR>,"action":"labeled"}`)
|
E.g.: `ngbuilds.io/pr-updated` (payload: `{"number":<PR>,"action":"labeled"}`)
|
||||||
|
|
|
@ -61,6 +61,6 @@ purposes. Each command is backed by a corresponding script inside
|
||||||
for more info.
|
for more info.
|
||||||
|
|
||||||
- `aio-dev-mode`:
|
- `aio-dev-mode`:
|
||||||
Links external source files (from the Docker host) to interal source files (in the Docker
|
Links external source files (from the Docker host) to internal source files (in the Docker
|
||||||
container). This makes it easier to use an IDE to edit files in the host that are then
|
container). This makes it easier to use an IDE to edit files in the host that are then
|
||||||
tested in the container. See the [debugging docs](misc--debug-docker-container.md) for more info.
|
tested in the container. See the [debugging docs](misc--debug-docker-container.md) for more info.
|
|
@ -69,7 +69,7 @@ This section describes how each of the aforementioned sub-tasks is accomplished:
|
||||||
We perform a number of preliminary checks:
|
We perform a number of preliminary checks:
|
||||||
- Was the webhook triggered by the designated CircleCI job (currently `aio_preview`)?
|
- Was the webhook triggered by the designated CircleCI job (currently `aio_preview`)?
|
||||||
- Was the build successful?
|
- Was the build successful?
|
||||||
- Are the associated GitHub organisation and repository what we expect (e.g. `angular/angular`)?
|
- Are the associated GitHub organization and repository what we expect (e.g. `angular/angular`)?
|
||||||
- Has the PR touched any files that might affect the angular.io app (currently the `aio/` or
|
- Has the PR touched any files that might affect the angular.io app (currently the `aio/` or
|
||||||
`packages/` directories, ignoring spec files)?
|
`packages/` directories, ignoring spec files)?
|
||||||
|
|
||||||
|
|
|
@ -106,7 +106,7 @@ Pass an empty string to remove the status.
|
||||||
|
|
||||||
<code-example
|
<code-example
|
||||||
path="cli-builder/src/my-builder.ts"
|
path="cli-builder/src/my-builder.ts"
|
||||||
header="src/my-builder.ts (progess reporting)"
|
header="src/my-builder.ts (progress reporting)"
|
||||||
region="progress-reporting">
|
region="progress-reporting">
|
||||||
</code-example>
|
</code-example>
|
||||||
|
|
||||||
|
|
|
@ -136,7 +136,7 @@ The [example-boilerplate.js](./example-boilerplate.js) script installs the depen
|
||||||
|
|
||||||
It also contains a function to remove all the boilerplate.
|
It also contains a function to remove all the boilerplate.
|
||||||
It uses `git clean -xdf` to do the job.
|
It uses `git clean -xdf` to do the job.
|
||||||
It will remove all files that are not tracked by git, **including any new files that you are working on that haven't been stageg yet.**
|
It will remove all files that are not tracked by git, **including any new files that you are working on that haven't been staged yet.**
|
||||||
So, be sure to commit your work before removing the boilerplate.
|
So, be sure to commit your work before removing the boilerplate.
|
||||||
|
|
||||||
|
|
||||||
|
|
|
@ -209,7 +209,7 @@ yarn bazel analyze-profile filename_name.profile --task_tree ".*"
|
||||||
```
|
```
|
||||||
|
|
||||||
To show all tasks that take longer than a certain threshold, use the `--task_tree_threshold` flag.
|
To show all tasks that take longer than a certain threshold, use the `--task_tree_threshold` flag.
|
||||||
The default behaviour is to use a 50ms threshold.
|
The default behavior is to use a 50ms threshold.
|
||||||
```
|
```
|
||||||
yarn bazel analyze-profile filename_name.profile --task_tree ".*" --task_tree_threshold 5000
|
yarn bazel analyze-profile filename_name.profile --task_tree ".*" --task_tree_threshold 5000
|
||||||
```
|
```
|
||||||
|
|
|
@ -74,7 +74,7 @@ Detailed triage can be done by anyone familiar with the issue subject matter.
|
||||||
|
|
||||||
Gauge whether the issue has enough information to act upon. This typically includes a test case
|
Gauge whether the issue has enough information to act upon. This typically includes a test case
|
||||||
via StackBlitz or GitHub and steps to reproduce. If the issue may be legitimate but needs more
|
via StackBlitz or GitHub and steps to reproduce. If the issue may be legitimate but needs more
|
||||||
information, add the "needs clarification" label. These labels can be revisted if the author can
|
information, add the "needs clarification" label. These labels can be revisited if the author can
|
||||||
provide further clarification. If the issue does have enough information, move on to step 2.
|
provide further clarification. If the issue does have enough information, move on to step 2.
|
||||||
|
|
||||||
### Step 2: Bug, feature, or discussion?
|
### Step 2: Bug, feature, or discussion?
|
||||||
|
@ -168,7 +168,7 @@ Targeting an active release train:
|
||||||
|
|
||||||
Special Cases:
|
Special Cases:
|
||||||
* `target: rc`: A critical fix for an active release-train while it is in a feature freeze or RC phase
|
* `target: rc`: A critical fix for an active release-train while it is in a feature freeze or RC phase
|
||||||
* `target: lts`: A criticial fix for a specific release-train that is still within the long term support phase
|
* `target: lts`: A critical fix for a specific release-train that is still within the long term support phase
|
||||||
|
|
||||||
|
|
||||||
Notes:
|
Notes:
|
||||||
|
|
Loading…
Reference in New Issue