honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(compiler-cli): infer quote expressions as any type in type checker (#37917) 

"Quote expressions" are expressions that start with an identifier followed by a
comma, allowing arbitrary syntax to follow. These kinds of expressions would
throw a an error in the template type checker, which would make them hard to
track down. As quote expressions are not generally used at all, the error would
typically occur for URLs that would inadvertently occur in a binding:

```html
<a [href]="https://example.com"></a>
```

This commit lets such bindings be inferred as the `any` type.

Fixes #36568
Resolves FW-2051

PR Close #37917
This commit is contained in:
JoostK 2020-07-04 00:16:18 +02:00 committed by Andrew Kushnir
parent 18098d38b8
commit 80b67e02b7
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/compiler-cli/src/ngtsc/typecheck/src/expression.ts
View File

@ -234,8 +234,8 @@ class AstTranslator implements AstVisitor {
return node; return node;
} }
visitQuote(ast: Quote): never { visitQuote(ast: Quote): ts.Expression {
throw new Error('Method not implemented.'); return NULL_AS_ANY;
} }
visitSafeMethodCall(ast: SafeMethodCall): ts.Expression { visitSafeMethodCall(ast: SafeMethodCall): ts.Expression {

5
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
View File

@ -42,6 +42,11 @@ describe('type check blocks', () => {
.toContain('(((ctx).a) ? ((ctx).b) : (((ctx).c) ? ((ctx).d) : ((ctx).e)))'); .toContain('(((ctx).a) ? ((ctx).b) : (((ctx).c) ? ((ctx).d) : ((ctx).e)))');
}); });
it('should handle quote expressions as any type', () => {
const TEMPLATE = `<span [quote]="sql:expression"></span>`;
expect(tcb(TEMPLATE)).toContain('null as any');
});
it('should handle attribute values for directive inputs', () => { it('should handle attribute values for directive inputs', () => {
const TEMPLATE = `<div dir inputA="value"></div>`; const TEMPLATE = `<div dir inputA="value"></div>`;
const DIRECTIVES: TestDeclaration[] = [{ const DIRECTIVES: TestDeclaration[] = [{