honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(aio): make tests less flaky (#19784) 

PR Close #19784
This commit is contained in:
Tobias Bosch 2017-10-18 08:50:00 -07:00
parent b0c7ea8181
commit 81173b0d29
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
aio/content/examples/component-styles/e2e/app.e2e-spec.ts
View File

@ -12,8 +12,10 @@ describe('Component Style Tests', function () {
let componentH1 = element(by.css('app-root > h1')); let componentH1 = element(by.css('app-root > h1'));
let externalH1 = element(by.css('body > h1')); let externalH1 = element(by.css('body > h1'));
expect(componentH1.getCssValue('fontWeight')).toEqual('normal'); // Note: sometimes webdriver returns the fontWeight as "normal",
expect(externalH1.getCssValue('fontWeight')).not.toEqual('normal'); // othertimes as "400", both of which are equal in CSS terms.
expect(componentH1.getCssValue('fontWeight')).toMatch(/normal|400/);
expect(externalH1.getCssValue('fontWeight')).not.toMatch(/normal|400/);
}); });

4
aio/e2e/app.e2e-spec.ts
View File

@ -66,7 +66,9 @@ describe('site App', function() {
}); });
}); });
describe('google analytics', () => { // TODO(https://github.com/angular/angular/issues/19785): Activate this again
// once it is no more flaky.
xdescribe('google analytics', () => {
beforeEach(done => page.gaReady.then(done)); beforeEach(done => page.gaReady.then(done));
it('should call ga', done => { it('should call ga', done => {