honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(bazel): compile targets used for indexing by Kythe with Ivy (#31786)

Browse Source 
This switches all Angular targets to be built with the same Angular compiler architecture (c.n. Ivy) that the Angular indexer uses. This eliminates issues with cross-references to transitive dependencies not being generated because of the way such dependencies are loaded by the legacy compiler arch.

PR Close #31786
This commit is contained in:
Ayaz Hafiz 2019-07-22 12:24:14 -07:00 committed by Misko Hevery
parent 44039a4b16
commit 82055b2fb8
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/bazel/src/ng_module.bzl
View File

@ -42,6 +42,11 @@ def compile_strategy(ctx):
if "compile" in ctx.var: if "compile" in ctx.var:
strategy = ctx.var["compile"] strategy = ctx.var["compile"]
# Enable Angular targets extracted by Kythe Angular indexer to be compiled with the Ivy compiler architecture.
# TODO(ayazhafiz): remove once Ivy has landed as the default in g3.
if ctx.var.get("GROK_ELLIPSIS_BUILD", None) != None:
strategy = "aot"
if strategy not in ["legacy", "aot"]: if strategy not in ["legacy", "aot"]:
fail("Unknown --define=compile value '%s'" % strategy) fail("Unknown --define=compile value '%s'" % strategy)