From 8536df16d97fccfbbaf23c9badf54d40eb9720ad Mon Sep 17 00:00:00 2001 From: yjbanov Date: Wed, 19 Aug 2015 15:29:36 -0700 Subject: [PATCH] chore(build): fail experimental Dart build but allow Travis failures --- .travis.yml | 1 + tools/build/dartanalyzer.js | 15 +++------------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index db7f319fd3..7a0664c57f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,6 +42,7 @@ env: matrix: allow_failures: - env: "MODE=saucelabs DART_CHANNEL=dev" + - env: "MODE=dart_experimental DART_CHANNEL=dev" addons: firefox: "38.0" diff --git a/tools/build/dartanalyzer.js b/tools/build/dartanalyzer.js index 7321fe2cf8..5c1f68ab68 100644 --- a/tools/build/dartanalyzer.js +++ b/tools/build/dartanalyzer.js @@ -107,19 +107,10 @@ module.exports = function(gulp, plugins, config) { if (report.length > 0) { error = 'Dartanalyzer showed ' + report.join(', '); } - if (useDdc) { - // TODO(yjbanov): fail the build when: - // - DDC analyzer is stable enough - // - We have cleaned up all DDC warnings - console.log(error); - done(); - } else { - done(error); - } + done(error); }); - stream.on('error', function(e) { - // TODO(yjbanov): fail the build when DDC is stable enough - console.log('ERROR: failed to run DDC at all: ' + e); + stream.on('error', function(error) { + done(error); }); } };