honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(platform-server): ensure compatibility with noImplicitOverride (#42512) 

Adds the `override` keyword to the `platform-server` sources to ensure
compatibility with `noImplicitOverride`.

PR Close #42512
This commit is contained in:
Paul Gschwendtner 2021-06-07 21:03:01 +02:00 committed by Andrew Kushnir
parent 48c9a0ddc6
commit 8948c93024
3 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
packages/platform-server/src/domino_adapter.ts
View File

@ -36,34 +36,34 @@ export function serializeDocument(doc: Document): string {
* DOM Adapter for the server platform based on https://github.com/fgnass/domino.
*/
export class DominoAdapter extends BrowserDomAdapter {
static makeCurrent() {
static override makeCurrent() {
setDomTypes();
setRootDomAdapter(new DominoAdapter());
}
readonly supportsDOMEvents = false;
override readonly supportsDOMEvents = false;
private static defaultDoc: Document;
createHtmlDocument(): HTMLDocument {
override createHtmlDocument(): HTMLDocument {
return parseDocument('<html><head><title>fakeTitle</title></head><body></body></html>');
}
getDefaultDocument(): Document {
override getDefaultDocument(): Document {
if (!DominoAdapter.defaultDoc) {
DominoAdapter.defaultDoc = domino.createDocument();
}
return DominoAdapter.defaultDoc;
}
isElementNode(node: any): boolean {
override isElementNode(node: any): boolean {
return node ? node.nodeType === DominoAdapter.defaultDoc.ELEMENT_NODE : false;
}
isShadowRoot(node: any): boolean {
override isShadowRoot(node: any): boolean {
return node.shadowRoot == node;
}
/** @deprecated No longer being used in Ivy code. To be removed in version 14. */
getGlobalEventTarget(doc: Document, target: string): EventTarget|null {
override getGlobalEventTarget(doc: Document, target: string): EventTarget|null {
if (target === 'window') {
return doc.defaultView;
}
@ -76,12 +76,12 @@ export class DominoAdapter extends BrowserDomAdapter {
return null;
}
getBaseHref(doc: Document): string {
override getBaseHref(doc: Document): string {
// TODO(alxhub): Need relative path logic from BrowserDomAdapter here?
return doc.documentElement!.querySelector('base')?.getAttribute('href') || '';
}
dispatchEvent(el: Node, evt: any) {
override dispatchEvent(el: Node, evt: any) {
el.dispatchEvent(evt);
// Dispatch the event to the window also.
@ -92,11 +92,11 @@ export class DominoAdapter extends BrowserDomAdapter {
}
}
getUserAgent(): string {
override getUserAgent(): string {
return 'Fake user agent';
}
getCookie(name: string): string {
override getCookie(name: string): string {
throw new Error('getCookie has not been implemented');
}
}

2
packages/platform-server/src/server_renderer.ts
View File

@ -267,7 +267,7 @@ class EmulatedEncapsulationServerRenderer2 extends DefaultServerRenderer2 {
super.setAttribute(element, this.hostAttr, '');
}
createElement(parent: any, name: string): Element {
override createElement(parent: any, name: string): Element {
const el = super.createElement(parent, name, this.document);
super.setAttribute(el, this.contentAttr, '');
return el;

2
packages/platform-server/src/styles_host.ts
View File

@ -33,7 +33,7 @@ export class ServerStylesHost extends SharedStylesHost {
this._styleNodes.add(el);
}
onStylesAdded(additions: Set<string>) {
override onStylesAdded(additions: Set<string>) {
additions.forEach(style => this._addStyle(style));
}