honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: add info about reviewing PRs from code owners (#32108) 

PR Close #32108
This commit is contained in:
George Kalpakas 2019-08-12 21:21:00 +03:00 committed by Andrew Kushnir
parent 843881120a
commit 8af85d812d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/TRIAGE_AND_LABELS.md
View File

@ -12,7 +12,7 @@ The owner of the component is then responsible for the secondary / component-lev
The caretaker should be able to determine which component the issue belongs to.
The components have a clear piece of source code associated with it within the `/packages/` folder of this repo.
* `comp: docs-infra` - the angular.io application
* `comp: docs-infra` - the angular.io application and docs-related tooling
* `comp: animations`
* `comp: bazel` - @angular/bazel rules
* `comp: benchpress`
@ -170,7 +170,9 @@ If a PR is missing the `PR target: *` label, or if the label is set to "TBD" whe
Before a PR can be merged it must be approved by the appropriate reviewer(s).
To ensure that the right people review each change, we configured [GitHub CODEOWNERS](https://help.github.com/articles/about-codeowners/) (via `.github/CODEOWNERS`) and require that each PR has at least one approval from the appropriate code owner.
To ensure that the right people review each change, we configured [GitHub CODEOWNERS](https://help.github.com/articles/about-codeowners/) (via `.github/CODEOWNERS`) and require that each PR has at least one approval from an appropriate code owner.
If the PR author is a code owner themselves, the approval can come from _any_ repo collaborator (person with write access). GitHub CODEOWNERs does not support this scenario, so the `merge-assistance` label must be added, mentioning that the PR author is a code owner. In any case, the reviewer should actually look through the code and provide feedback if necessary.
Note that approved state does not mean a PR is ready to be merged.
For example, a reviewer might approve the PR but request a minor tweak that doesn't need further review, e.g., a rebase or small uncontroversial change.