honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: add info about who adds/removes labels in TRIAGE_AND_LABELS.md (#30171)

Browse Source 
PR Close #30171
This commit is contained in:
George Kalpakas 2019-05-18 00:20:46 +03:00 committed by Jason Aden
parent a50c1bb7bc
commit 8c00fced1c
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
docs/TRIAGE_AND_LABELS.md
View File

@ -120,17 +120,27 @@ Triaging PRs is the same as triaging issues, except that the labels `frequency:
PRs also have additional label categories that should be used to signal their state. PRs also have additional label categories that should be used to signal their state.
Every triaged PR must have a `pr_action` label assigned to it: Every triaged PR must have a `PR action` label assigned to it:
* `PR action: cleanup` - more work is needed from the author. * `PR action: discuss`: Discussion is needed, to be led by the author.
* `PR action: discuss` - discussion is needed, to be led by the author. * _**Who adds it:** Typically the PR author._
* `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready". * _**Who removes it:** Whoever added it._
* `PR action: cleanup`: More work is needed from the author.
* _**Who adds it:** The reviewer requesting changes to the PR._
* _**Who removes it:** Either the author (after implementing the requested changes) or the reviewer (after confirming the requested changes have been implemented)._
* `PR action: merge`: The PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready".
* _**Who adds it:** Typically the PR author._
* _**Who removes it:** Whoever added it._
In addition, PRs can have the following states: In addition, PRs can have the following states:
* `PR state: WIP` - PR is experimental or rapidly changing. Not ready for review or triage. * `PR state: WIP`: PR is experimental or rapidly changing. Not ready for review or triage.
* `PR state: blocked` - PR is blocked on an issue or other PR. Not ready for review or triage or merge. * _**Who adds it:** The PR author._
* _**Who removes it:** Whoever added it._
* `PR state: blocked`: PR is blocked on an issue or other PR. Not ready for merge.
* _**Who adds it:** Any team member._
* _**Who removes it:** Any team member._
When a PR is ready for review, a review should be requested using the Reviewers interface in Github. When a PR is ready for review, a review should be requested using the Reviewers interface in Github.
@ -167,14 +177,23 @@ Only the `PR action: merge` label means that the PR is ready for merging.
## Special Labels ## Special Labels
### `cla: yes`, `cla: no` ### `cla: yes`, `cla: no`
* _**Who adds it:** @googlebot, or a Googler manually overriding the status in case the bot got it wrong._
* _**Who removes it:** @googlebot._
Managed by googlebot. Managed by googlebot.
Indicates whether a PR has a CLA on file for its author(s). Indicates whether a PR has a CLA on file for its author(s).
Only issues with `cla:yes` should be merged into master. Only issues with `cla:yes` should be merged into master.
### `aio: preview` ### `aio: preview`
* _**Who adds it:** Any team member. (Typically the author or a reviewer.)_
* _**Who removes it:** Any team member. (Typically, whoever added it.)_
Applying this label to a PR makes the angular.io preview available regardless of the author. [More info](../aio/aio-builds-setup/docs/overview--security-model.md) Applying this label to a PR makes the angular.io preview available regardless of the author. [More info](../aio/aio-builds-setup/docs/overview--security-model.md)
### `PR action: merge-assistance` ### `PR action: merge-assistance`
* _**Who adds it:** Any team member._
* _**Who removes it:** Any team member._
This label can be added to let the caretaker know that the PR needs special attention. This label can be added to let the caretaker know that the PR needs special attention.
There should always be a comment added to the PR to explain why the caretaker's assistance is needed. There should always be a comment added to the PR to explain why the caretaker's assistance is needed.
The comment should be formatted like this: `merge-assistance: <explain what kind of assistance you need, and if not obvious why>` The comment should be formatted like this: `merge-assistance: <explain what kind of assistance you need, and if not obvious why>`