honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(bazel): enable ivy template type-checking in g3 (#35672) 

Template type-checking within the Ivy compiler has been disabled internally
in g3 until compatibility with the whole codebase could be verified. As that
verification is now complete and template type-checking is known to be
compatible with g3, this commit enables it.

PR Close #35672
This commit is contained in:
Alex Rickabaugh 2020-02-25 12:37:10 -08:00 committed by Miško Hevery
parent 184a8493c8
commit 8f5b7f367c
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/bazel/src/ng_module.bzl
View File

@ -306,9 +306,6 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
"enableSummariesForJit": is_legacy_ngc,
"enableIvy": is_ivy_enabled(ctx),
"fullTemplateTypeCheck": ctx.attr.type_check,
# TODO(alxhub/arick): template type-checking in g3 is currently disabled because of
# preexisting failures. Reenable once g3 is fixed: FW-1753
"ivyTemplateTypeCheck": _is_bazel(),
# In Google3 we still want to use the symbol factory re-exports in order to
# not break existing apps inside Google. Unlike Bazel, Google3 does not only
# enforce strict dependencies of source files, but also for generated files