test(core): remove "enableIvy" compiler option from migration tests (#32954)

ec4381d explicitly set `enableIvy: false` for all migrations inside
the core package. This actually hides migration issues because the
migration itself should ensure that it instantiates the right
compiler program if it relies on `@angular/compiler-cli`.

We should remove these options from all migration tests to
ensure that we catch issues with migrations running in version
9 where Ivy is enabled by default.

e.g. e5636a322c
was accidentally hidden due to the `enableIvy: false` option.

PR Close #32954

packages/core/schematics/test/google3/explicit_query_timing_rule_spec.ts

@@ -26,10 +26,7 @@ describe('Google3 explicitQueryTiming TSLint rule', () => {
     tmpDir = join(process.env['TEST_TMPDIR'] !, 'google3-test');
     shx.mkdir('-p', tmpDir);
 
-    writeFile(
+    writeFile('tsconfig.json', JSON.stringify({compilerOptions: {module: 'es2015'}}));
-        'tsconfig.json',
-        JSON.stringify(
-            {compilerOptions: {module: 'es2015'}, angularCompilerOptions: {enableIvy: false}}));
   });
 
   afterEach(() => shx.rm('-r', tmpDir));

packages/core/schematics/test/google3/missing_injectable_rule_spec.ts

@@ -21,10 +21,7 @@ describe('Google3 missing injectable tslint rule', () => {
     tmpDir = join(process.env['TEST_TMPDIR'] !, 'google3-test');
     shx.mkdir('-p', tmpDir);
 
-    writeFile(
+    writeFile('tsconfig.json', JSON.stringify({compilerOptions: {module: 'es2015'}}));
-        'tsconfig.json',
-        JSON.stringify(
-            {compilerOptions: {module: 'es2015'}, angularCompilerOptions: {enableIvy: false}}));
   });
 
   afterEach(() => shx.rm('-r', tmpDir));

packages/core/schematics/test/google3/no_template_variable_assignment_rule_spec.ts

@@ -21,10 +21,7 @@ describe('Google3 noTemplateVariableAssignment TSLint rule', () => {
     tmpDir = join(process.env['TEST_TMPDIR'] !, 'google3-test');
     shx.mkdir('-p', tmpDir);
 
-    writeFile(
+    writeFile('tsconfig.json', JSON.stringify({compilerOptions: {module: 'es2015'}}));
-        'tsconfig.json',
-        JSON.stringify(
-            {compilerOptions: {module: 'es2015'}, angularCompilerOptions: {enableIvy: false}}));
   });
 
   afterEach(() => shx.rm('-r', tmpDir));

packages/core/schematics/test/google3/renderer_to_renderer2_spec.ts

@@ -35,7 +35,6 @@ describe('Google3 Renderer to Renderer2 TSLint rule', () => {
           '@angular/core': ['angular.d.ts'],
         }
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
   });
 

packages/core/schematics/test/missing_injectable_migration_spec.ts

@@ -30,7 +30,6 @@ describe('Missing injectable migration', () => {
         experimentalDecorators: true,
         lib: ['es2015'],
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
     writeFile('/angular.json', JSON.stringify({
       projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}

packages/core/schematics/test/move_document_migration_spec.ts

@@ -28,7 +28,6 @@ describe('move-document migration', () => {
       compilerOptions: {
         lib: ['es2015'],
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
     writeFile('/angular.json', JSON.stringify({
       projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}

packages/core/schematics/test/renderer_to_renderer2_migration_spec.ts

@@ -29,7 +29,6 @@ describe('Renderer to Renderer2 migration', () => {
         lib: ['es2015'],
         strictNullChecks: true,
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
     writeFile('/angular.json', JSON.stringify({
       projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}

packages/core/schematics/test/static_queries_migration_usage_spec.ts

@@ -35,7 +35,6 @@ describe('static-queries migration with usage strategy', () => {
       compilerOptions: {
         lib: ['es2015'],
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
     writeFile('/angular.json', JSON.stringify({
       projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}

packages/core/schematics/test/template_var_assignment_migration_spec.ts

@@ -29,7 +29,6 @@ describe('template variable assignment migration', () => {
       compilerOptions: {
         lib: ['es2015'],
       },
-      angularCompilerOptions: {enableIvy: false}
     }));
     writeFile('/angular.json', JSON.stringify({
       projects: {t: {architect: {build: {options: {tsConfig: './tsconfig.json'}}}}}

packages/core/schematics/test/undecorated_classes_with_di_migration_spec.ts

@@ -1308,7 +1308,6 @@ describe('Undecorated classes with DI migration', () => {
         generateCodeForLibraries: false,
         allowEmptyCodegenFiles: true,
         enableSummariesForJit: true,
-        enableIvy: false,
       }
     }));