honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ngcc): slightly improve the info in error messages (#34254) 

PR Close #34254
This commit is contained in:
Pete Bacon Darwin 2019-12-18 14:03:05 +00:00 committed by Kara Erickson
parent 31be29a9f3
commit 918d8c9909
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/compiler-cli/ngcc/src/main.ts
View File

@ -271,7 +271,7 @@ export function mainNgcc(
const errors = replaceTsWithNgInErrors( const errors = replaceTsWithNgInErrors(
ts.formatDiagnosticsWithColorAndContext(result.diagnostics, bundle.src.host)); ts.formatDiagnosticsWithColorAndContext(result.diagnostics, bundle.src.host));
throw new Error( throw new Error(
`Failed to compile entry-point ${entryPoint.name} due to compilation errors:\n${errors}`); `Failed to compile entry-point ${entryPoint.name} (${formatProperty} as ${format}) due to compilation errors:\n${errors}`);
} }
logger.debug(` Successfully compiled ${entryPoint.name} : ${formatProperty}`); logger.debug(` Successfully compiled ${entryPoint.name} : ${formatProperty}`);

2
packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
View File

@ -797,7 +797,7 @@ runInEachFileSystem(() => {
fail('should have thrown'); fail('should have thrown');
} catch (e) { } catch (e) {
expect(e.message).toContain( expect(e.message).toContain(
'Failed to compile entry-point fatal-error due to compilation errors:'); 'Failed to compile entry-point fatal-error (es2015 as esm2015) due to compilation errors:');
expect(e.message).toContain('NG2001'); expect(e.message).toContain('NG2001');
expect(e.message).toContain('component is missing a template'); expect(e.message).toContain('component is missing a template');
} }