test(ngcc): use `DelegatingReflectionHost` for testing `NgccReflectionHost`s (#36284)

Browse Source

In #36089, `DelegatingReflectionHost` was introduced. Under the hood, it
delegates another `NgccReflectionHost` in order to reflect over the
program's source files, while using a different TypeScript
`ReflectionHost` to reflect over `.d.ts` files (which is how external
dependencies are represented in the program).

Previously, the `NgccReflectionHost`s were used directly in tests. This
does not exercise them in the way they are exercised in the actual
program, because (when used directly) they will also reflect on `.d.ts`
files too (instead of delegating to the TypeScript `ReflectionHost`).
This could hide bugs that would happen on the actual program.

This commit fixes this by using the `DelegatingReflectionHost` in the
various `NgccReflectionHost` tests.

NOTE:
This change will cause some of the existing tests to start failing.
These failures demonstrate pre-existing bugs in ngcc, that were hidden
due to the tests' being inconsistent with how the `ReflectionHost`s are
used in the actual program. They will be fixed in the next commit.

PR Close #36284

...

This commit is contained in:

George Kalpakas 2020-04-03 16:37:45 +03:00 committed by Kara Erickson

parent 0af6e9fcbb

commit 93f07aee6c

4 changed files with 1156 additions and 969 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

565

packages/compiler-cli/ngcc/test/host/commonjs_host_spec.ts

View File

File diff suppressed because it is too large Load Diff

509

packages/compiler-cli/ngcc/test/host/esm2015_host_spec.ts

View File

File diff suppressed because it is too large Load Diff

540

packages/compiler-cli/ngcc/test/host/esm5_host_spec.ts

View File

File diff suppressed because it is too large Load Diff

511

packages/compiler-cli/ngcc/test/host/umd_host_spec.ts

View File

File diff suppressed because it is too large Load Diff