build: enable TSLint on the packages folder

packages/animations/browser/src/dsl/animation_ast_builder.ts

@@ -201,7 +201,7 @@ export class AnimationAstBuilderVisitor implements AnimationDslVisitor {
         } else {
           styles.push(styleTuple as ɵStyleData);
         }
-      })
+      });
     } else {
       styles.push(metadata.styles);
     }

packages/animations/browser/src/render/animation_engine_next.ts

@@ -29,8 +29,8 @@ export class AnimationEngine {
     this._transitionEngine = new TransitionAnimationEngine(driver, normalizer);
     this._timelineEngine = new TimelineAnimationEngine(driver, normalizer);
 
-    this._transitionEngine.onRemovalComplete =
+    this._transitionEngine.onRemovalComplete = (element: any, context: any) =>
-        (element: any, context: any) => { this.onRemovalComplete(element, context); }
+        this.onRemovalComplete(element, context);
   }
 
   registerTrigger(

packages/animations/browser/src/render/transition_animation_engine.ts

@@ -490,6 +490,7 @@ export class TransitionAnimationEngine {
   // this method is designed to be overridden by the code that uses this engine
   public onRemovalComplete = (element: any, context: any) => {};
 
+  /** @internal */
   _onRemovalComplete(element: any, context: any) { this.onRemovalComplete(element, context); }
 
   constructor(public driver: AnimationDriver, private _normalizer: AnimationStyleNormalizer) {}

packages/animations/browser/test/dsl/animation_spec.ts

@@ -427,17 +427,17 @@ export function main() {
 
         it('should throw an error when an input variable is not provided when invoked and is not a default value',
            () => {
-             expect(() => {invokeAnimationSequence(rootElement, [style({color: '{{ color }}'})])})
+             expect(() => invokeAnimationSequence(rootElement, [style({color: '{{ color }}'})]))
                  .toThrowError(/Please provide a value for the animation param color/);
 
              expect(
-                 () => {invokeAnimationSequence(
+                 () => invokeAnimationSequence(
                      rootElement,
                      [
                        style({color: '{{ start }}'}),
                        animate('{{ time }}', style({color: '{{ end }}'})),
                      ],
-                     buildParams({start: 'blue', end: 'red'}))})
+                     buildParams({start: 'blue', end: 'red'})))
                  .toThrowError(/Please provide a value for the animation param time/);
            });
       });

packages/animations/browser/test/dsl/animation_trigger_spec.ts

@@ -182,7 +182,7 @@ export function main() {
            const trans = buildTransition(result, element, false, true) !;
            expect(trans.timelines[0].keyframes).toEqual([
              {offset: 0, color: 'red'}, {offset: 1, color: 'green'}
-           ])
+           ]);
          });
 
       it('should match `1` and `0` state styles on a `true <=> false` boolean transition given boolean values',
@@ -195,7 +195,7 @@ export function main() {
            const trans = buildTransition(result, element, false, true) !;
            expect(trans.timelines[0].keyframes).toEqual([
              {offset: 0, color: 'orange'}, {offset: 1, color: 'blue'}
-           ])
+           ]);
          });
 
       describe('aliases', () => {

packages/common/http/src/request.ts

@@ -15,8 +15,11 @@ import {HttpParams} from './params';
  * All values are optional and will override default values if provided.
  */
 interface HttpRequestInit {
-  headers?: HttpHeaders, reportProgress?: boolean, params?: HttpParams,
+  headers?: HttpHeaders;
-      responseType?: 'arraybuffer'|'blob'|'json'|'text', withCredentials?: boolean,
+  reportProgress?: boolean;
+  params?: HttpParams;
+  responseType?: 'arraybuffer'|'blob'|'json'|'text';
+  withCredentials?: boolean;
 }
 
 /**

packages/common/http/src/response.ts

@@ -120,7 +120,10 @@ export interface HttpUserEvent<T> { type: HttpEventType.User; }
  *
  * @experimental
  */
-export interface HttpJsonParseError { error: Error, text: string, }
+export interface HttpJsonParseError {
+  error: Error;
+  text: string;
+}
 
 /**
  * Union type for all possible events on the response stream.
@@ -233,7 +236,7 @@ export class HttpHeaderResponse extends HttpResponseBase {
       status: update.status !== undefined ? update.status : this.status,
       statusText: update.statusText || this.statusText,
       url: update.url || this.url || undefined,
-    })
+    });
   }
 }
 

packages/common/http/src/xhr.ts

@@ -268,27 +268,26 @@ export class HttpXhrBackend implements HttpBackend {
 
       // The upload progress event handler, which is only registered if
       // progress events are enabled.
-      const onUpProgress =
+      const onUpProgress = (event: ProgressEvent) => {
-          (event: ProgressEvent) => {
+        // Upload progress events are simpler. Begin building the progress
-            // Upload progress events are simpler. Begin building the progress
+        // event.
-            // event.
+        let progress: HttpUploadProgressEvent = {
-            let progress: HttpUploadProgressEvent = {
+          type: HttpEventType.UploadProgress,
-              type: HttpEventType.UploadProgress,
+          loaded: event.loaded,
-              loaded: event.loaded,
+        };
-            };
 
-            // If the total number of bytes being uploaded is available, include
+        // If the total number of bytes being uploaded is available, include
-            // it.
+        // it.
-            if (event.lengthComputable) {
+        if (event.lengthComputable) {
-              progress.total = event.total;
+          progress.total = event.total;
-            }
+        }
 
-            // Send the event.
+        // Send the event.
-            observer.next(progress);
+        observer.next(progress);
-          }
+      };
 
-                                    // By default, register for load and error events.
+      // By default, register for load and error events.
-                                    xhr.addEventListener('load', onLoad);
+      xhr.addEventListener('load', onLoad);
       xhr.addEventListener('error', onError);
 
       // Progress events are only enabled if requested.

packages/common/http/test/jsonp_spec.ts

@@ -56,11 +56,11 @@ export function main() {
     });
     describe('throws an error', () => {
       it('when request method is not JSONP',
-         () => {expect(() => backend.handle(SAMPLE_REQ.clone<never>({method: 'GET'})))
+         () => expect(() => backend.handle(SAMPLE_REQ.clone<never>({method: 'GET'})))
-                    .toThrowError(JSONP_ERR_WRONG_METHOD)});
+                   .toThrowError(JSONP_ERR_WRONG_METHOD));
       it('when response type is not json',
-         () => {expect(() => backend.handle(SAMPLE_REQ.clone<never>({responseType: 'text'})))
+         () => expect(() => backend.handle(SAMPLE_REQ.clone<never>({responseType: 'text'})))
-                    .toThrowError(JSONP_ERR_WRONG_RESPONSE_TYPE)});
+                   .toThrowError(JSONP_ERR_WRONG_RESPONSE_TYPE));
       it('when callback is never called', (done: DoneFn) => {
         backend.handle(SAMPLE_REQ).subscribe(undefined, (err: HttpErrorResponse) => {
           expect(err.status).toBe(0);
@@ -69,7 +69,7 @@ export function main() {
           done();
         });
         document.mockLoad();
-      })
+      });
     });
   });
 }

packages/common/http/test/params_spec.ts

@@ -13,7 +13,7 @@ export function main() {
     describe('initialization', () => {
       it('should be empty at construction', () => {
         const body = new HttpParams();
-        expect(body.toString()).toEqual('')
+        expect(body.toString()).toEqual('');
       });
 
       it('should parse an existing url', () => {

packages/common/http/test/xhr_spec.ts

@@ -271,7 +271,7 @@ export function main() {
           done();
         });
         factory.mock.mockFlush(200, 'OK', 'Test');
-      })
+      });
     });
     describe('corrects for quirks', () => {
       it('by normalizing 1223 status to 204', (done: DoneFn) => {

packages/common/http/test/xsrf_spec.ts

@@ -64,7 +64,7 @@ export function main() {
   });
   describe('HttpXsrfCookieExtractor', () => {
     let document: {[key: string]: string};
-    let extractor: HttpXsrfCookieExtractor
+    let extractor: HttpXsrfCookieExtractor;
     beforeEach(() => {
       document = {
         cookie: 'XSRF-TOKEN=test',

packages/common/http/testing/src/backend.ts

@@ -126,7 +126,7 @@ export class HttpClientTestingBackend implements HttpBackend, HttpTestingControl
       const requests = open.map(testReq => {
                              const url = testReq.request.urlWithParams.split('?')[0];
                              const method = testReq.request.method;
-                             return `${method} ${url}`
+                             return `${method} ${url}`;
                            })
                            .join(', ');
       throw new Error(`Expected no open requests, found ${open.length}: ${requests}`);

packages/compiler-cli/src/codegen.ts

@@ -96,7 +96,7 @@ export class CodeGenerator {
       }
     }
     if (!transContent) {
-      missingTranslation = MissingTranslationStrategy.Ignore
+      missingTranslation = MissingTranslationStrategy.Ignore;
     }
     const {compiler: aotCompiler} = compiler.createAotCompiler(ngCompilerHost, {
       translations: transContent,

packages/compiler-cli/src/diagnostics/check_types.ts

@@ -203,11 +203,9 @@ class TypeCheckingHost implements ts.CompilerHost {
   }
 
   writeFile: ts.WriteFileCallback =
-      () => { throw new Error('Unexpected write in diagnostic program'); }
+      () => { throw new Error('Unexpected write in diagnostic program'); };
 
-  getCurrentDirectory(): string {
+  getCurrentDirectory(): string { return this.host.getCurrentDirectory(); }
-    return this.host.getCurrentDirectory();
-  }
 
   getDirectories(path: string): string[] { return this.host.getDirectories(path); }
 

packages/compiler-cli/src/ngc.ts

@@ -136,12 +136,11 @@ export function performCompilation(
 
     const rootFileNames = files.map(f => path.normalize(f));
 
-    const addGeneratedFileName =
+    const addGeneratedFileName = (fileName: string) => {
-        (fileName: string) => {
+      if (fileName.startsWith(basePath) && TS_EXT.exec(fileName)) {
-          if (fileName.startsWith(basePath) && TS_EXT.exec(fileName)) {
+        rootFileNames.push(fileName);
-            rootFileNames.push(fileName);
+      }
-          }
+    };
-        }
 
     if (ngOptions.flatModuleOutFile && !ngOptions.skipMetadataEmit) {
       const {host: bundleHost, indexName, errors} =

packages/compiler-cli/src/transformers/lower_expressions.ts

@@ -63,7 +63,7 @@ function transformSourceFile(
       const result = ts.visitEachChild(node, visitNode, context);
 
       if (declarations.length) {
-        inserts.push({priorTo: result, declarations})
+        inserts.push({priorTo: result, declarations});
       }
       return result;
     }
@@ -113,7 +113,7 @@ export function getExpressionLoweringTransformFactory(requestsMap: RequestsMap):
   return (context: ts.TransformationContext) => (sourceFile: ts.SourceFile): ts.SourceFile => {
     const requests = requestsMap.getRequests(sourceFile);
     if (requests && requests.size) {
-      return transformSourceFile(sourceFile, requests, context)
+      return transformSourceFile(sourceFile, requests, context);
     }
     return sourceFile;
   };
@@ -155,12 +155,11 @@ export class LowerMetadataCache implements RequestsMap {
     let identNumber = 0;
     const freshIdent = () => '\u0275' + identNumber++;
     const requests = new Map<number, LoweringRequest>();
-    const replaceNode =
+    const replaceNode = (node: ts.Node) => {
-        (node: ts.Node) => {
+      const name = freshIdent();
-          const name = freshIdent();
+      requests.set(node.pos, {name, kind: node.kind, location: node.pos, end: node.end});
-          requests.set(node.pos, {name, kind: node.kind, location: node.pos, end: node.end});
+      return {__symbolic: 'reference', name};
-          return {__symbolic: 'reference', name};
+    };
-        }
 
     const substituteExpression = (value: MetadataValue, node: ts.Node): MetadataValue => {
       if (node.kind === ts.SyntaxKind.ArrowFunction ||

packages/compiler-cli/src/transformers/module_filename_resolver.ts

@@ -9,8 +9,7 @@
 import * as path from 'path';
 import * as ts from 'typescript';
 
-import {ModuleFilenameResolver} from './api';
+import {CompilerOptions, ModuleFilenameResolver} from './api';
-import {CompilerOptions} from './api';
 
 const EXT = /(\.ts|\.d\.ts|\.js|\.jsx|\.tsx)$/;
 const DTS = /\.d\.ts$/;

packages/compiler-cli/src/transformers/node_emitter.ts

@@ -32,7 +32,7 @@ export class TypeScriptNodeEmitter {
       }
       statements[0] = ts.setSyntheticLeadingComments(
           statements[0],
-          [{kind: ts.SyntaxKind.MultiLineCommentTrivia, text: preamble, pos: -1, end: -1}])
+          [{kind: ts.SyntaxKind.MultiLineCommentTrivia, text: preamble, pos: -1, end: -1}]);
     }
     return [newSourceFile, converter.getNodeMap()];
   }
@@ -279,7 +279,7 @@ class _NodeEmitterVisitor implements StatementVisitor, ExpressionVisitor {
     return this.record(
         expr, ts.createCall(
                   expr.fn.visitExpression(this, null), /* typeArguments */ undefined,
-                  expr.args.map(arg => arg.visitExpression(this, null))))
+                  expr.args.map(arg => arg.visitExpression(this, null))));
   }
 
   visitInstantiateExpr(expr: InstantiateExpr): RecordedNode<ts.NewExpression> {

packages/compiler-cli/src/transformers/program.ts

@@ -15,8 +15,7 @@ import * as ts from 'typescript';
 import {CompilerHost as AotCompilerHost, CompilerHostContext} from '../compiler_host';
 import {TypeChecker} from '../diagnostics/check_types';
 
-import {CompilerHost, CompilerOptions, DiagnosticCategory} from './api';
+import {CompilerHost, CompilerOptions, Diagnostic, DiagnosticCategory, EmitFlags, Program} from './api';
-import {Diagnostic, EmitFlags, Program} from './api';
 import {LowerMetadataCache, getExpressionLoweringTransformFactory} from './lower_expressions';
 import {getAngularEmitterTransformFactory} from './node_emitter_transform';
 
@@ -144,7 +143,7 @@ class AngularCompilerProgram implements Program {
   }
 
   private get structuralDiagnostics(): Diagnostic[] {
-    return this.analyzedModules && this._structuralDiagnostics
+    return this.analyzedModules && this._structuralDiagnostics;
   }
 
   private get stubs(): GeneratedFile[] {
@@ -171,7 +170,7 @@ class AngularCompilerProgram implements Program {
   }
 
   private get generatedFiles(): GeneratedFile[] {
-    return this._generatedFiles || (this._generatedFiles = this.generateFiles())
+    return this._generatedFiles || (this._generatedFiles = this.generateFiles());
   }
 
   private get typeChecker(): TypeChecker {
@@ -343,7 +342,7 @@ function createProgramWithStubsHost(
     generatedFiles: GeneratedFile[], originalProgram: ts.Program,
     originalHost: ts.CompilerHost): ts.CompilerHost {
   interface FileData {
-    g: GeneratedFile
+    g: GeneratedFile;
     s?: ts.SourceFile;
   }
   return new class implements ts.CompilerHost {

packages/compiler-cli/test/diagnostics/mocks.ts

@@ -110,12 +110,14 @@ const summaryResolver = new AotSummaryResolver(
     staticSymbolCache);
 
 export class DiagnosticContext {
+  // tslint:disable
   _analyzedModules: NgAnalyzedModules;
   _staticSymbolResolver: StaticSymbolResolver|undefined;
   _reflector: StaticReflector|undefined;
   _errors: {e: any, path?: string}[] = [];
   _resolver: CompileMetadataResolver|undefined;
   _refletor: StaticReflector;
+  // tslint:enable
 
   constructor(
       public service: ts.LanguageService, public program: ts.Program,

packages/compiler-cli/test/diagnostics/symbol_query_spec.ts

@@ -45,7 +45,7 @@ describe('symbol query', () => {
     options.basePath = '/quickstart';
     const aotHost = new CompilerHost(program, options, host, {verboseInvalidExpression: true});
     context = new DiagnosticContext(service, program, checker, aotHost);
-    query = getSymbolQuery(program, checker, sourceFile, emptyPipes)
+    query = getSymbolQuery(program, checker, sourceFile, emptyPipes);
   });
 
   it('should be able to get undefined for an unknown symbol', () => {

packages/compiler-cli/test/ngc_spec.ts

@@ -437,12 +437,11 @@ describe('ngc command-line', () => {
         throw new Error(`Expected ${fileName} to be emitted (outDir: ${outDir})`);
       }
     };
-    const shouldNotExist =
+    const shouldNotExist = (fileName: string) => {
-        (fileName: string) => {
+      if (fs.existsSync(path.resolve(outDir, fileName))) {
-          if (fs.existsSync(path.resolve(outDir, fileName))) {
+        throw new Error(`Did not expect ${fileName} to be emitted (outDir: ${outDir})`);
-            throw new Error(`Did not expect ${fileName} to be emitted (outDir: ${outDir})`);
+      }
-          }
+    };
-        }
 
     it('should be able to generate a flat module library', () => {
       writeConfig(`

packages/compiler/src/aot/compiler_options.ts

@@ -14,5 +14,5 @@ export interface AotCompilerOptions {
   translations?: string;
   missingTranslation?: MissingTranslationStrategy;
   enableLegacyTemplate?: boolean;
-  enableSummariesForJit?: boolean
+  enableSummariesForJit?: boolean;
 }

packages/compiler/src/aot/static_reflector.ts

@@ -621,7 +621,7 @@ export class StaticReflector implements CompileReflector {
               }
               return simplifyInContext(context, value, depth, references + 1);
             }
-            return simplify(value)
+            return simplify(value);
           });
         }
         return IGNORE;

packages/compiler/src/ml_parser/ast.ts

@@ -142,7 +142,7 @@ export function findNode(nodes: Node[], position: number): HtmlAstPath {
         return true;
       }
     }
-  }
+  };
 
   visitAll(visitor, nodes);
 

packages/compiler/src/output/output_ast.ts

@@ -228,7 +228,7 @@ export class ReadVarExpr extends Expression {
 
   set(value: Expression): WriteVarExpr {
     if (!this.name) {
-      throw new Error(`Built in variable ${this.builtin} can not be assigned to.`)
+      throw new Error(`Built in variable ${this.builtin} can not be assigned to.`);
     }
     return new WriteVarExpr(this.name, value, null, this.sourceSpan);
   }

packages/compiler/test/aot/compiler_spec.ts

@@ -28,7 +28,7 @@ describe('compiler (unbundled Angular)', () => {
 
   describe('aot source mapping', () => {
     const componentPath = '/app/app.component.ts';
-    const ngComponentPath = 'ng:///app/app.component.ts'
+    const ngComponentPath = 'ng:///app/app.component.ts';
 
     let rootDir: MockDirectory;
     let appDir: MockDirectory;

packages/compiler/test/i18n/extractor_merger_spec.ts

@@ -490,7 +490,7 @@ export function main() {
             .toEqual(
                 '<span someAttr="ok">foo</span><div>{count, plural, =0 {<p title="foo"></p>}}</div>');
       });
-    })
+    });
   });
 }
 

packages/compiler/test/output/output_jit_spec.ts

@@ -31,5 +31,5 @@ export function main() {
         expect(Object.keys(args).length).toBe(20);
       });
     });
-  })
+  });
 }

packages/compiler/test/parse_util_spec.ts

@@ -6,23 +6,21 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ParseError, ParseErrorLevel, ParseLocation, ParseSourceFile, ParseSourceSpan} from '../src/parse_util'
+import {ParseError, ParseErrorLevel, ParseLocation, ParseSourceFile, ParseSourceSpan} from '../src/parse_util';
 
 export function main() {
-  describe(
+  describe('ParseError', () => {
-      'ParseError',
+    it('should reflect the level in the message', () => {
-      () => {
+      const file = new ParseSourceFile(`foo\nbar\nfoo`, 'url');
-        it('should reflect the level in the message', () => {
+      const start = new ParseLocation(file, 4, 1, 0);
-          const file = new ParseSourceFile(`foo\nbar\nfoo`, 'url');
+      const end = new ParseLocation(file, 6, 1, 2);
-          const start = new ParseLocation(file, 4, 1, 0);
+      const span = new ParseSourceSpan(start, end);
-          const end = new ParseLocation(file, 6, 1, 2);
-          const span = new ParseSourceSpan(start, end);
 
-          const fatal = new ParseError(span, 'fatal', ParseErrorLevel.ERROR);
+      const fatal = new ParseError(span, 'fatal', ParseErrorLevel.ERROR);
-          expect(fatal.toString()).toEqual('fatal ("foo\n[ERROR ->]bar\nfoo"): url@1:0');
+      expect(fatal.toString()).toEqual('fatal ("foo\n[ERROR ->]bar\nfoo"): url@1:0');
 
-          const warning = new ParseError(span, 'warning', ParseErrorLevel.WARNING);
+      const warning = new ParseError(span, 'warning', ParseErrorLevel.WARNING);
-          expect(warning.toString()).toEqual('warning ("foo\n[WARNING ->]bar\nfoo"): url@1:0');
+      expect(warning.toString()).toEqual('warning ("foo\n[WARNING ->]bar\nfoo"): url@1:0');
-        });
+    });
-      });
+  });
 }

packages/core/src/application_init.ts

@@ -45,11 +45,10 @@ export class ApplicationInitStatus {
 
     const asyncInitPromises: Promise<any>[] = [];
 
-    const complete =
+    const complete = () => {
-        () => {
+      this._done = true;
-          this._done = true;
+      this.resolve();
-          this.resolve();
+    };
-        }
 
     if (this.appInits) {
       for (let i = 0; i < this.appInits.length; i++) {

packages/core/src/change_detection/differs/default_iterable_differ.ts

@@ -52,11 +52,9 @@ export class DefaultIterableDiffer<V> implements IterableDiffer<V>, IterableChan
   // Keeps track of records where custom track by is the same, but item identity has changed
   private _identityChangesHead: IterableChangeRecord_<V>|null = null;
   private _identityChangesTail: IterableChangeRecord_<V>|null = null;
-  private _trackByFn: TrackByFunction<V>
+  private _trackByFn: TrackByFunction<V>;
 
-  constructor(trackByFn?: TrackByFunction<V>) {
+  constructor(trackByFn?: TrackByFunction<V>) { this._trackByFn = trackByFn || trackByIdentity; }
-    this._trackByFn = trackByFn || trackByIdentity;
-  }
 
   get collection() { return this._collection; }
 

packages/core/src/view/refs.ts

@@ -466,7 +466,8 @@ export function createNgModuleRef(
 class NgModuleRef_ implements NgModuleData, InternalNgModuleRef<any> {
   private _destroyListeners: (() => void)[] = [];
   private _destroyed: boolean = false;
-  public _providers: any[];
+  /** @internal */
+  _providers: any[];
 
   constructor(
       private _moduleType: Type<any>, public _parent: Injector,

packages/core/test/animation/animation_integration_spec.ts

@@ -1882,7 +1882,7 @@ export function main() {
            class Cmp {
              exp: string;
              log: any[] = [];
-             callback = (event: any) => { this.log.push(`${event.phaseName} => ${event.toState}`); }
+             callback = (event: any) => this.log.push(`${event.phaseName} => ${event.toState}`);
            }
 
            TestBed.configureTestingModule({

packages/core/test/application_init_spec.ts

@@ -35,7 +35,7 @@ export function main() {
           return () => {
             const initStatus = injector.get(ApplicationInitStatus);
             initStatus.donePromise.then(() => { expect(completerResolver).toBe(true); });
-          }
+          };
         };
         promise = new Promise((res) => { resolve = res; });
         TestBed.configureTestingModule({

packages/core/test/linker/change_detection_integration_spec.ts

@@ -1353,7 +1353,7 @@ export function main() {
           tpl: TemplateRef<any>;
 
           @Input()
-          outerTpl: TemplateRef<any>
+          outerTpl: TemplateRef<any>;
 
           constructor(public cdRef: ChangeDetectorRef) {}
           log(id: string) { log.push(`inner-${id}`); }

packages/forms/src/directives/default_value_accessor.ts

@@ -83,14 +83,17 @@ export class DefaultValueAccessor implements ControlValueAccessor {
     this._renderer.setProperty(this._elementRef.nativeElement, 'disabled', isDisabled);
   }
 
+  /** @internal */
   _handleInput(value: any): void {
     if (!this._compositionMode || (this._compositionMode && !this._composing)) {
       this.onChange(value);
     }
   }
 
+  /** @internal */
   _compositionStart(): void { this._composing = true; }
 
+  /** @internal */
   _compositionEnd(value: any): void {
     this._composing = false;
     this._compositionMode && this.onChange(value);

packages/forms/test/form_group_spec.ts

@@ -41,7 +41,7 @@ export function main() {
     return e;
   }
 
-  function otherObservableValidator() { return of ({'other': true}) }
+  function otherObservableValidator() { return of ({'other': true}); }
 
   describe('FormGroup', () => {
     describe('value', () => {

packages/forms/test/reactive_integration_spec.ts

@@ -1116,7 +1116,7 @@ export function main() {
 
            tick(100);
            expect(resultArr.length)
-               .toEqual(2, `Expected original observable to be canceled on the next value change.`)
+               .toEqual(2, `Expected original observable to be canceled on the next value change.`);
          }));
 
 

packages/forms/test/value_accessor_integration_spec.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
 import {Component, Directive, EventEmitter, Input, Output, Type} from '@angular/core';
 import {ComponentFixture, TestBed, async, fakeAsync, tick} from '@angular/core/testing';
 import {AbstractControl, ControlValueAccessor, FormControl, FormGroup, FormsModule, NG_VALIDATORS, NG_VALUE_ACCESSOR, NgControl, NgForm, ReactiveFormsModule, Validators} from '@angular/forms';

packages/platform-browser/test/security/html_sanitizer_spec.ts

@@ -123,7 +123,7 @@ export function main() {
         // depending on the browser, we might ge an exception
       }
       try {
-        sanitizeHtml(defaultDoc, '<form><input name="nextSibling" /></form>')
+        sanitizeHtml(defaultDoc, '<form><input name="nextSibling" /></form>');
       } catch (e) {
         // depending on the browser, we might ge an exception
       }

packages/router/src/apply_redirects.ts

@@ -444,8 +444,11 @@ function match(segmentGroup: UrlSegmentGroup, route: Route, segments: UrlSegment
 
   if (!res) {
     return {
-      matched: false, consumedSegments: <any[]>[], lastChild: 0, positionalParamSegments: {},
+      matched: false,
-    }
+      consumedSegments: <any[]>[],
+      lastChild: 0,
+      positionalParamSegments: {},
+    };
   }
 
   return {

packages/router/src/router.ts

@@ -1128,7 +1128,7 @@ class ActivateRoutes {
       const children: {[outletName: string]: any} = nodeChildrenAsMap(route);
       const contexts = route.value.component ? context.children : parentContexts;
 
-      forEach(children, (v: any, k: string) => {this.deactivateRouteAndItsChildren(v, contexts)});
+      forEach(children, (v: any, k: string) => this.deactivateRouteAndItsChildren(v, contexts));
 
       if (context.outlet) {
         // Destroy the component

packages/router/src/utils/collection.ts

@@ -64,7 +64,7 @@ export function forEach<K, V>(map: {[key: string]: V}, callback: (v: V, k: strin
 export function waitForMap<A, B>(
     obj: {[k: string]: A}, fn: (k: string, a: A) => Observable<B>): Observable<{[k: string]: B}> {
   if (Object.keys(obj).length === 0) {
-    return of ({})
+    return of ({});
   }
 
   const waitHead: Observable<B>[] = [];

packages/router/test/integration.spec.ts

@@ -1070,7 +1070,7 @@ describe('Integration', () => {
                 return map.call(of (null), () => {
                   log.push('resolver2');
                   observer.next(null);
-                  observer.complete()
+                  observer.complete();
                 });
               }
             },

packages/tsc-wrapped/test/evaluator_spec.ts

@@ -259,9 +259,9 @@ describe('Evaluator', () => {
       const expr = findVar(source, 'a');
       expect(evaluator.evaluateNode(expr !.initializer !)).toEqual([
         {provide: 'someValue', useFactory: {__symbolic: 'reference', name: lambdaTemp}}
-      ])
+      ]);
     });
-  })
+  });
 });
 
 function sourceFileOf(text: string): ts.SourceFile {

packages/tsc-wrapped/test/typescript.mocks.ts

@@ -1,3 +1,11 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
 import * as fs from 'fs';
 import * as ts from 'typescript';
 
@@ -70,7 +78,7 @@ export class MockNode implements ts.Node {
       public kind: ts.SyntaxKind = ts.SyntaxKind.Identifier, public flags: ts.NodeFlags = 0,
       public pos: number = 0, public end: number = 0) {}
   getSourceFile(): ts.SourceFile { return null as any as ts.SourceFile; }
-  getChildCount(sourceFile?: ts.SourceFile): number { return 0 }
+  getChildCount(sourceFile?: ts.SourceFile): number { return 0; }
   getChildAt(index: number, sourceFile?: ts.SourceFile): ts.Node { return null as any as ts.Node; }
   getChildren(sourceFile?: ts.SourceFile): ts.Node[] { return []; }
   getStart(sourceFile?: ts.SourceFile): number { return 0; }
@@ -90,12 +98,14 @@ export class MockNode implements ts.Node {
 
 export class MockIdentifier extends MockNode implements ts.Identifier {
   public text: string;
+  // tslint:disable
   public _primaryExpressionBrand: any;
   public _memberExpressionBrand: any;
   public _leftHandSideExpressionBrand: any;
   public _incrementExpressionBrand: any;
   public _unaryExpressionBrand: any;
   public _expressionBrand: any;
+  // tslint:enable
 
   constructor(
       public name: string, public kind: ts.SyntaxKind.Identifier = ts.SyntaxKind.Identifier,
@@ -106,6 +116,7 @@ export class MockIdentifier extends MockNode implements ts.Identifier {
 }
 
 export class MockVariableDeclaration extends MockNode implements ts.VariableDeclaration {
+  // tslint:disable-next-line
   public _declarationBrand: any;
 
   constructor(
@@ -130,7 +141,7 @@ export class MockSymbol implements ts.Symbol {
   getDeclarations(): ts.Declaration[] { return [this.node]; }
   getDocumentationComment(): ts.SymbolDisplayPart[] { return []; }
   // TODO(vicb): removed in TS 2.2
-  getJsDocTags(): any[]{return []};
+  getJsDocTags(): any[] { return []; }
 
   static of (name: string): MockSymbol { return new MockSymbol(name); }
 }
@@ -139,6 +150,7 @@ export function expectNoDiagnostics(diagnostics: ts.Diagnostic[]) {
   for (const diagnostic of diagnostics) {
     const message = ts.flattenDiagnosticMessageText(diagnostic.messageText, '\n');
     const {line, character} = diagnostic.file.getLineAndCharacterOfPosition(diagnostic.start);
+    // tslint:disable-next-line:no-console
     console.log(`${diagnostic.file.fileName} (${line + 1},${character + 1}): ${message}`);
   }
   expect(diagnostics.length).toBe(0);
@@ -159,7 +171,7 @@ export function allChildren<T>(node: ts.Node, cb: (node: ts.Node) => T): T {
       return result;
     }
     return allChildren(child, cb);
-  })
+  });
 }
 
 export function findClass(sourceFile: ts.SourceFile, name: string): ts.ClassDeclaration|undefined {

tools/gulp-tasks/lint.js

@@ -9,6 +9,7 @@ module.exports = (gulp) => () => {
         // todo(vicb): add .js files when supported
         // see https://github.com/palantir/tslint/pull/1515
         './modules/**/*.ts',
+        './packages/**/*.ts',
         './tools/**/*.ts',
         './*.ts',
 

tools/public_api_guard/forms/forms.d.ts

@@ -144,9 +144,6 @@ export declare class DefaultValueAccessor implements ControlValueAccessor {
     onChange: (_: any) => void;
     onTouched: () => void;
     constructor(_renderer: Renderer2, _elementRef: ElementRef, _compositionMode: boolean);
-    _compositionEnd(value: any): void;
-    _compositionStart(): void;
-    _handleInput(value: any): void;
     registerOnChange(fn: (_: any) => void): void;
     registerOnTouched(fn: () => void): void;
     setDisabledState(isDisabled: boolean): void;