honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ivy): separate first creation pass in the text instruction (#33894) 

PR Close #33894
This commit is contained in:
Pawel Kozlowski 2019-11-18 11:23:47 +01:00 committed by Alex Rickabaugh
parent ffa3936b4c
commit 96499c898f
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/core/src/render3/instructions/text.ts
View File

@ -6,10 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/
import {assertDataInRange, assertEqual} from '../../util/assert';
import {TNodeType} from '../interfaces/node';
import {TElementNode, TNodeType} from '../interfaces/node';
import {HEADER_OFFSET, RENDERER, TVIEW, T_HOST} from '../interfaces/view';
import {appendChild, createTextNode} from '../node_manipulation';
import {getBindingIndex, getLView, setIsNotParent} from '../state';
import {getBindingIndex, getLView, setPreviousOrParentTNode} from '../state';
import {getOrCreateTNode} from './shared';
@ -25,14 +25,21 @@ import {getOrCreateTNode} from './shared';
*/
export function ɵɵtext(index: number, value: string = ''): void {
const lView = getLView();
const tView = lView[TVIEW];
const adjustedIndex = index + HEADER_OFFSET;
ngDevMode && assertEqual(
getBindingIndex(), lView[TVIEW].bindingStartIndex,
getBindingIndex(), tView.bindingStartIndex,
'text nodes should be created before any bindings');
ngDevMode && assertDataInRange(lView, index + HEADER_OFFSET);
const textNative = lView[index + HEADER_OFFSET] = createTextNode(value, lView[RENDERER]);
const tNode = getOrCreateTNode(lView[TVIEW], lView[T_HOST], index, TNodeType.Element, null, null);
ngDevMode && assertDataInRange(lView, adjustedIndex);
const tNode = tView.firstCreatePass ?
getOrCreateTNode(tView, lView[T_HOST], index, TNodeType.Element, null, null) :
tView.data[adjustedIndex] as TElementNode;
const textNative = lView[adjustedIndex] = createTextNode(value, lView[RENDERER]);
appendChild(textNative, tNode, lView);
// Text nodes are self closing.
setIsNotParent();
appendChild(textNative, tNode, lView);
setPreviousOrParentTNode(tNode, false);
}

3
packages/core/test/bundling/hello_world/bundle.golden_symbols.json
View File

@ -464,9 +464,6 @@
{
"name": "setInjectImplementation"
},
{
"name": "setIsNotParent"
},
{
"name": "setPreviousOrParentTNode"
},