From 9ae14db343a59821758b47d6683058cac6a6e768 Mon Sep 17 00:00:00 2001 From: Keen Yee Liau Date: Wed, 20 Feb 2019 19:34:05 -0800 Subject: [PATCH] fix(bazel): rxjs_umd_modules should always be present (#28881) This commit fixes the bug whereby `rxjs_umd_modules` would only be generated when Sass files are used. PR closes https://github.com/angular/angular/issues/28878 PR Close #28881 --- .../files/src/BUILD.bazel.template | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/bazel/src/schematics/bazel-workspace/files/src/BUILD.bazel.template b/packages/bazel/src/schematics/bazel-workspace/files/src/BUILD.bazel.template index dac6e0ce7a..1a729de597 100644 --- a/packages/bazel/src/schematics/bazel-workspace/files/src/BUILD.bazel.template +++ b/packages/bazel/src/schematics/bazel-workspace/files/src/BUILD.bazel.template @@ -7,15 +7,6 @@ load("@build_bazel_rules_nodejs//internal/web_package:web_package.bzl", "web_pac load("@build_bazel_rules_typescript//:defs.bzl", "ts_devserver", "ts_library") <% if (sass) { %>load("@io_bazel_rules_sass//:defs.bzl", "multi_sass_binary") -filegroup( - name = "rxjs_umd_modules", - srcs = [ - # do not sort - "@npm//node_modules/rxjs:bundles/rxjs.umd.js", - ":rxjs_shims.js", - ], -) - multi_sass_binary( name = "styles", srcs = glob(["**/*.scss"]), @@ -73,6 +64,15 @@ history_server( templated_args = ["src/prodapp"], ) +filegroup( + name = "rxjs_umd_modules", + srcs = [ + # do not sort + "@npm//node_modules/rxjs:bundles/rxjs.umd.js", + ":rxjs_shims.js", + ], +) + ts_devserver( name = "devserver", port = 4200,