honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ngcc): move `stripParentheses` to `Esm5ReflectionHost` for re-use (#33777) 

PR Close #33777
This commit is contained in:
Pete Bacon Darwin 2019-11-13 08:33:22 +00:00 committed by Kara Erickson
parent 7f24975a60
commit 9c6ee5fcd0
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler-cli/ngcc/src/host/esm5_host.ts
View File

@ -14,8 +14,6 @@ import {getNameText, hasNameIdentifier, stripDollarSuffix} from '../utils';
import {Esm2015ReflectionHost, ParamInfo, getPropertyValueFromSymbol, isAssignmentStatement} from './esm2015_host'; import {Esm2015ReflectionHost, ParamInfo, getPropertyValueFromSymbol, isAssignmentStatement} from './esm2015_host';
import {NgccClassSymbol} from './ngcc_host'; import {NgccClassSymbol} from './ngcc_host';
/** /**
* ESM5 packages contain ECMAScript IIFE functions that act like classes. For example: * ESM5 packages contain ECMAScript IIFE functions that act like classes. For example:
* *
@ -834,3 +832,7 @@ function isUndefinedComparison(expression: ts.Expression): expression is ts.Expr
expression.operatorToken.kind === ts.SyntaxKind.EqualsEqualsEqualsToken && expression.operatorToken.kind === ts.SyntaxKind.EqualsEqualsEqualsToken &&
ts.isVoidExpression(expression.right) && ts.isIdentifier(expression.left); ts.isVoidExpression(expression.right) && ts.isIdentifier(expression.left);
} }
export function stripParentheses(node: ts.Node): ts.Node {
return ts.isParenthesizedExpression(node) ? node.expression : node;
}

6
packages/compiler-cli/ngcc/src/host/umd_host.ts
View File

@ -12,7 +12,7 @@ import {absoluteFrom} from '../../../src/ngtsc/file_system';
import {Declaration, Import} from '../../../src/ngtsc/reflection'; import {Declaration, Import} from '../../../src/ngtsc/reflection';
import {Logger} from '../logging/logger'; import {Logger} from '../logging/logger';
import {BundleProgram} from '../packages/bundle_program'; import {BundleProgram} from '../packages/bundle_program';
import {Esm5ReflectionHost} from './esm5_host'; import {Esm5ReflectionHost, stripParentheses} from './esm5_host';
export class UmdReflectionHost extends Esm5ReflectionHost { export class UmdReflectionHost extends Esm5ReflectionHost {
protected umdModules = new Map<ts.SourceFile, UmdModule|null>(); protected umdModules = new Map<ts.SourceFile, UmdModule|null>();
@ -279,7 +279,3 @@ function findNamespaceOfIdentifier(id: ts.Identifier): ts.Identifier|null {
id.parent.expression : id.parent.expression :
null; null;
} }
export function stripParentheses(node: ts.Node): ts.Node {
return ts.isParenthesizedExpression(node) ? node.expression : node;
}