honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(animations): use `ngDevMode` to tree-shake warning (#39964) 

This commit adds ngDevMode guard to show warning only
in dev mode (similar to how things work in other parts of Ivy runtime code).
The ngDevMode flag helps to tree-shake this warning from production builds
(in dev mode everything will work as it works right now) to decrease production bundle size.

PR Close #39964
This commit is contained in:
arturovt 2020-12-04 12:58:53 +02:00 committed by Misko Hevery
parent f022efa06f
commit 9ebe42370a
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/animations/browser/src/render/css_keyframes/css_keyframes_driver.ts
View File

@ -21,7 +21,6 @@ const TAB_SPACE = ' ';
export class CssKeyframesDriver implements AnimationDriver { export class CssKeyframesDriver implements AnimationDriver {
private _count = 0; private _count = 0;
private readonly _head: any = document.querySelector('head'); private readonly _head: any = document.querySelector('head');
private _warningIssued = false;
validateStyleProperty(prop: string): boolean { validateStyleProperty(prop: string): boolean {
return validateStyleProperty(prop); return validateStyleProperty(prop);
@ -79,8 +78,8 @@ export class CssKeyframesDriver implements AnimationDriver {
animate( animate(
element: any, keyframes: ɵStyleData[], duration: number, delay: number, easing: string, element: any, keyframes: ɵStyleData[], duration: number, delay: number, easing: string,
previousPlayers: AnimationPlayer[] = [], scrubberAccessRequested?: boolean): AnimationPlayer { previousPlayers: AnimationPlayer[] = [], scrubberAccessRequested?: boolean): AnimationPlayer {
if (scrubberAccessRequested) { if ((typeof ngDevMode === 'undefined' || ngDevMode) && scrubberAccessRequested) {
this._notifyFaultyScrubber(); notifyFaultyScrubber();
} }
const previousCssKeyframePlayers = <CssKeyframesPlayer[]>previousPlayers.filter( const previousCssKeyframePlayers = <CssKeyframesPlayer[]>previousPlayers.filter(
@ -117,15 +116,6 @@ export class CssKeyframesDriver implements AnimationDriver {
player.onDestroy(() => removeElement(kfElm)); player.onDestroy(() => removeElement(kfElm));
return player; return player;
} }
private _notifyFaultyScrubber() {
if (!this._warningIssued) {
console.warn(
'@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',
' visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');
this._warningIssued = true;
}
}
} }
function flattenKeyframesIntoStyles(keyframes: null|{[key: string]: any}| function flattenKeyframesIntoStyles(keyframes: null|{[key: string]: any}|
@ -146,3 +136,12 @@ function flattenKeyframesIntoStyles(keyframes: null|{[key: string]: any}|
function removeElement(node: any) { function removeElement(node: any) {
node.parentNode.removeChild(node); node.parentNode.removeChild(node);
} }
let warningIssued = false;
function notifyFaultyScrubber(): void {
if (warningIssued) return;
console.warn(
'@angular/animations: please load the web-animations.js polyfill to allow programmatic access...\n',
' visit https://bit.ly/IWukam to learn more about using the web-animation-js polyfill.');
warningIssued = true;
}