From 9f538a6cac3004ed95d45d94abb69d0de7effa20 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mi=C5=A1ko=20Hevery?= Date: Wed, 27 Dec 2017 10:54:19 -0800 Subject: [PATCH] build: add karma tests for render3 (#21188) PR Close #21188 --- packages/core/test/render3/BUILD.bazel | 37 ++++++++++++++++++++--- packages/core/test/render3/render_util.ts | 3 +- 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/packages/core/test/render3/BUILD.bazel b/packages/core/test/render3/BUILD.bazel index aa9adcf7d2..b237d7c817 100644 --- a/packages/core/test/render3/BUILD.bazel +++ b/packages/core/test/render3/BUILD.bazel @@ -1,14 +1,18 @@ package(default_visibility = ["//visibility:public"]) -load("@build_bazel_rules_typescript//:defs.bzl", "ts_library") +load("@build_bazel_rules_typescript//:defs.bzl", "ts_library", "ts_web_test") load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test") ts_library( - name = "lib", + name = "render3_lib", testonly = 1, srcs = glob( ["**/*.ts"], - exclude = ["**/*_perf.ts"], + exclude = [ + "**/*_perf.ts", + "domino.d.ts", + "load_domino.ts", + ], ), tsconfig = "//packages:tsconfig.json", deps = [ @@ -22,12 +26,37 @@ ts_library( ], ) +ts_library( + name = "render3_node_lib", + testonly = 1, + srcs = [ + "domino.d.ts", + "load_domino.ts", + ], + tsconfig = "//packages:tsconfig", + deps = [ + ":render3_lib", + ], +) + jasmine_node_test( name = "render3", bootstrap = [ "angular_src/packages/core/test/render3/load_domino", ], deps = [ - ":lib", + ":render3_node_lib", + ], +) + +ts_web_test( + name = "render3_web", + bootstrap = [ + "//:web_test_bootstrap_scripts", + ], + # do not sort + deps = [ + "//tools/testing:browser", + ":render3_lib", ], ) diff --git a/packages/core/test/render3/render_util.ts b/packages/core/test/render3/render_util.ts index fab4ee4e4f..d08b7808b3 100644 --- a/packages/core/test/render3/render_util.ts +++ b/packages/core/test/render3/render_util.ts @@ -15,7 +15,8 @@ import {getRendererFactory2} from './imported_renderer2'; export const document = ((global || window) as any).document; export let containerEl: HTMLElement = null !; let host: LElement|null; -const isRenderer2 = process.argv[3] && process.argv[3] === '--r=renderer2'; +const isRenderer2 = + typeof process == 'object' && process.argv[3] && process.argv[3] === '--r=renderer2'; // tslint:disable-next-line:no-console console.log(`Running tests with ${!isRenderer2 ? 'document' : 'Renderer2'} renderer...`); const testRendererFactory: RendererFactory3 =