honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(router): incorrect signature for createUrlTree (#39347) 

The type of the `navigationExtras` param was accidetally changed to the wrong symbol
in 783a5bd7bb.
These changes revert it to the correct one.

PR Close #39347
This commit is contained in:
Kristiyan Kostadinov 2020-10-20 21:35:36 +02:00 committed by Andrew Kushnir
parent a7964f4eca
commit 9fb7bdea89
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
goldens/public-api/router/router.d.ts vendored
View File

@ -341,7 +341,7 @@ export declare class Router {
urlHandlingStrategy: UrlHandlingStrategy; urlHandlingStrategy: UrlHandlingStrategy;
urlUpdateStrategy: 'deferred' | 'eager'; urlUpdateStrategy: 'deferred' | 'eager';
constructor(rootComponentType: Type<any> | null, urlSerializer: UrlSerializer, rootContexts: ChildrenOutletContexts, location: Location, injector: Injector, loader: NgModuleFactoryLoader, compiler: Compiler, config: Routes); constructor(rootComponentType: Type<any> | null, urlSerializer: UrlSerializer, rootContexts: ChildrenOutletContexts, location: Location, injector: Injector, loader: NgModuleFactoryLoader, compiler: Compiler, config: Routes);
createUrlTree(commands: any[], navigationExtras?: NavigationExtras): UrlTree; createUrlTree(commands: any[], navigationExtras?: UrlCreationOptions): UrlTree;
dispose(): void; dispose(): void;
getCurrentNavigation(): Navigation | null; getCurrentNavigation(): Navigation | null;
initialNavigation(): void; initialNavigation(): void;

2
packages/router/src/router.ts
View File

@ -1096,7 +1096,7 @@ export class Router {
* router.createUrlTree(['../../team/44/user/22'], {relativeTo: route}); * router.createUrlTree(['../../team/44/user/22'], {relativeTo: route});
* ``` * ```
*/ */
createUrlTree(commands: any[], navigationExtras: NavigationExtras = {}): UrlTree { createUrlTree(commands: any[], navigationExtras: UrlCreationOptions = {}): UrlTree {
const {relativeTo, queryParams, fragment, queryParamsHandling, preserveFragment} = const {relativeTo, queryParams, fragment, queryParamsHandling, preserveFragment} =
navigationExtras; navigationExtras;
const a = relativeTo || this.routerState.root; const a = relativeTo || this.routerState.root;