refactor(bazel): convert most ts_library to ng_module (#22176)

This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close #22176

packages/animations/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "animations",
     srcs = glob(
         [

packages/animations/browser/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "browser",
     srcs = glob(
         [

packages/animations/browser/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/bazel/index.bzl

@@ -7,6 +7,6 @@
 Users should not load files under "/src"
 """
 
-load("//src:ng_module.bzl", _ng_module = "ng_module")
+load("//packages/bazel/src:ng_module.bzl", _ng_module = "ng_module")
 
 ng_module = _ng_module

packages/bazel/src/ngc-wrapped/BUILD.bazel

@@ -12,8 +12,8 @@ ts_library(
     visibility = ["//packages/bazel/test/ngc-wrapped:__subpackages__"],
     deps = [
         # BEGIN-INTERNAL
-        # Only needed when compiling Angular from sources.
+        # Only needed when compiling within the Angular repo.
-        # Users with an npm depnedency will get this dependency from node_modules.
+        # Users will get this dependency from node_modules.
         "//packages/compiler-cli",
         # END-INTERNAL
         "@build_bazel_rules_typescript//internal/tsc_wrapped",

packages/bazel/test/ngc-wrapped/BUILD.bazel

@@ -10,12 +10,8 @@ ts_library(
     ],
     tsconfig = ":tsconfig.json",
     deps = [
-        # BEGIN-INTERNAL
-        # Only needed when compiling within the Angular repo.
-        # Users will get this dependency from node_modules.
-        "//packages/compiler-cli",
-        # END-INTERNAL
         "//packages/bazel/src/ngc-wrapped:ngc_lib",
+        "//packages/compiler-cli",
     ],
 )
 

packages/common/http/testing/BUILD.bazel

@@ -1,10 +1,9 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(
         [
             "*.ts",

packages/common/testing/BUILD.bazel

@@ -1,10 +1,9 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/common/testing",
     deps = [

packages/compiler-cli/BUILD.bazel

@@ -22,6 +22,7 @@ ts_library(
         ],
     ),
     module_name = "@angular/compiler-cli",
+    node_modules = "@//:node_modules",
     tsconfig = ":tsconfig",
     deps = [
         "//packages/compiler",

packages/compiler-cli/tsconfig-build.json

@@ -12,6 +12,9 @@
     },
     "outDir": "../../dist/packages/compiler-cli"
   },
+  "bazelOptions": {
+    "suppressTsconfigOverrideWarnings": true
+  },
 
   "exclude": [
     "integrationtest"

packages/core/testing/BUILD.bazel

@@ -1,10 +1,9 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
-    testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/core/testing",
     deps = [

packages/core/testing/src/test_compiler.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {Compiler, CompilerOptions, Component, ComponentFactory, Directive, Injector, NgModule, Pipe, Type} from '@angular/core';
+import {Compiler, CompilerOptions, Component, ComponentFactory, Directive, Injectable, Injector, NgModule, Pipe, Type} from '@angular/core';
 
 import {MetadataOverride} from './metadata_override';
 
@@ -19,6 +19,7 @@ function unimplemented(): any {
  *
  * @experimental
  */
+@Injectable()
 export class TestingCompiler extends Compiler {
   get injector(): Injector { throw unimplemented(); }
   overrideModule(module: Type<any>, overrides: MetadataOverride<NgModule>): void {

packages/http/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/platform-browser-dynamic/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "platform-browser-dynamic",
     srcs = glob(
         [

packages/platform-browser-dynamic/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/platform-browser/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/platform-server/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/platform-webworker/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "platform-webworker",
     srcs = glob(
         [

packages/router/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "router",
     srcs = glob(
         [

packages/router/testing/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),

packages/service-worker/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "service-worker",
     srcs = glob(
         [

packages/service-worker/testing/BUILD.bazel

@@ -1,13 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "testing",
     testonly = 1,
     srcs = glob(["**/*.ts"]),
     module_name = "@angular/service-worker/testing",
     deps = [
+        "//packages/core",
         "@rxjs",
     ],
 )

packages/service-worker/worker/testing/BUILD.bazel

@@ -8,6 +8,7 @@ ts_library(
     srcs = glob(["**/*.ts"]),
     deps = [
         "//packages:types",
+        "//packages/core",
         "//packages/service-worker/worker",
         "@rxjs",
     ],

packages/service-worker/worker/tsconfig.json

@@ -15,6 +15,9 @@
     "target": "es2017",
     "typeRoots": []
   },
+  "bazelOptions": {
+    "suppressTsconfigOverrideWarnings": true
+  },
   "files": [
     "main.ts",
     "src/service-worker.d.ts"

packages/tsconfig.json

@@ -24,6 +24,9 @@
     "target": "es5",
     "types": ["angularjs"]
   },
+  "bazelOptions": {
+    "suppressTsconfigOverrideWarnings": true
+  },
   "exclude": [
     "bazel",
     "compiler-cli/integrationtest",

packages/upgrade/BUILD.bazel

@@ -1,8 +1,8 @@
 package(default_visibility = ["//visibility:public"])
 
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults.bzl", "ng_module")
 
-ts_library(
+ng_module(
     name = "upgrade",
     srcs = glob(
         [

tools/defaults.bzl

@@ -1,6 +1,6 @@
 """Re-export of some bazel rules with repository-wide defaults."""
 load("@build_bazel_rules_typescript//:defs.bzl", _ts_library = "ts_library")
-load("//packages/bazel/src:ng_module.bzl", _ng_module = "ng_module")
+load("//packages/bazel:index.bzl", _ng_module = "ng_module")
 
 DEFAULT_TSCONFIG = "//packages:tsconfig-build.json"
 
@@ -9,7 +9,7 @@ def ts_library(tsconfig = None, **kwargs):
     tsconfig = DEFAULT_TSCONFIG
   _ts_library(tsconfig = tsconfig, **kwargs)
 
-def ng_module(tsconfig = None, **kwargs):
+def ng_module(name, tsconfig = None, **kwargs):
   if not tsconfig:
     tsconfig = DEFAULT_TSCONFIG
-  _ng_module(tsconfig = tsconfig, **kwargs)
+  _ng_module(name = name, tsconfig = tsconfig, **kwargs)