honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ivy): fix fixmeIvy invocations in "platform-browser" tests (#27498) 

Some "platform-browser" tests were updated before `fixmeIvy` function contract was changed to `fixmeIvy(...).it(...)`, thus triggering failed tests to run on CI. This commit updates these cases to invoke `fixmeIvy` correctly.

PR Close #27498
This commit is contained in:
Andrew Kushnir 2018-12-05 16:12:24 -08:00 committed by Igor Minar
parent f514ac3da2
commit a315dedb85
2 changed files with 105 additions and 105 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/platform-browser/animations/test/animation_renderer_spec.ts
View File

@ -121,8 +121,8 @@ import {el} from '../../testing/src/browser_util';
if (isNode) return;
fixmeIvy(
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`) &&
it('should flush and fire callbacks when the zone becomes stable', (async) => {
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`)
.it('should flush and fire callbacks when the zone becomes stable', (async) => {
@Component({
selector: 'my-cmp',
template: '<div [@myAnimation]="exp" (@myAnimation.start)="onStart($event)"></div>',
@ -198,8 +198,8 @@ import {el} from '../../testing/src/browser_util';
});
fixmeIvy(
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`) &&
it('should only queue up dom removals if the element itself contains a valid leave animation',
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`)
.it('should only queue up dom removals if the element itself contains a valid leave animation',
() => {
@Component({
selector: 'my-cmp',
@ -284,8 +284,8 @@ import {el} from '../../testing/src/browser_util';
});
fixmeIvy(
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`) &&
it('should provide hooks at the start and end of change detection', () => {
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`)
.it('should provide hooks at the start and end of change detection', () => {
@Component({
selector: 'my-cmp',
template: `

8
packages/platform-browser/animations/test/noop_animations_module_spec.ts
View File

@ -20,8 +20,8 @@ import {fixmeIvy} from '@angular/private/testing';
// TODO: remove the dummy test above ^ once the bug FW-643 has been fixed
fixmeIvy(
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`) &&
it('should flush and fire callbacks when the zone becomes stable', (async) => {
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`)
.it('should flush and fire callbacks when the zone becomes stable', (async) => {
@Component({
selector: 'my-cmp',
template:
@ -56,8 +56,8 @@ import {fixmeIvy} from '@angular/private/testing';
});
fixmeIvy(
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`) &&
it('should handle leave animation callbacks even if the element is destroyed in the process',
`FW-643: Components with animations throw with "Failed to execute 'setAttribute' on 'Element'`)
.it('should handle leave animation callbacks even if the element is destroyed in the process',
(async) => {
@Component({
selector: 'my-cmp',