honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(dev-infra): require npm login for all publishes via wombat proxy (#41422) 

Due to an issue with wombat proxy returning the login state of the generated tokens,
we will need to require a login for all `ng-dev release publish` runs to ensure npm
login has occured.

PR Close #41422
This commit is contained in:
Joey Perrott 2021-04-01 15:34:14 -07:00 committed by atscott
parent 46a97b985e
commit a43f36babd
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dev-infra/ng-dev.js
View File

@ -6486,9 +6486,21 @@ class ReleaseTool {
* @returns a boolean indicating whether the user is logged into NPM. * @returns a boolean indicating whether the user is logged into NPM.
*/ */
_verifyNpmLoginState() { _verifyNpmLoginState() {
var _a; var _a, _b;
return tslib.__awaiter(this, void 0, void 0, function* () { return tslib.__awaiter(this, void 0, void 0, function* () {
const registry = `NPM at the ${(_a = this._config.publishRegistry) !== null && _a !== void 0 ? _a : 'default NPM'} registry`; const registry = `NPM at the ${(_a = this._config.publishRegistry) !== null && _a !== void 0 ? _a : 'default NPM'} registry`;
// TODO(josephperrott): remove wombat specific block once wombot allows `npm whoami` check to
// check the status of the local token in the .npmrc file.
if ((_b = this._config.publishRegistry) === null || _b === void 0 ? void 0 : _b.includes('wombat-dressing-room.appspot.com')) {
info('Unable to determine NPM login state for wombat proxy, requiring login now.');
try {
yield npmLogin(this._config.publishRegistry);
}
catch (_c) {
return false;
}
return true;
}
if (yield npmIsLoggedIn(this._config.publishRegistry)) { if (yield npmIsLoggedIn(this._config.publishRegistry)) {
debug(`Already logged into ${registry}.`); debug(`Already logged into ${registry}.`);
return true; return true;
@ -6500,7 +6512,7 @@ class ReleaseTool {
try { try {
yield npmLogin(this._config.publishRegistry); yield npmLogin(this._config.publishRegistry);
} }
catch (_b) { catch (_d) {
return false; return false;
} }
return true; return true;

11
dev-infra/release/publish/index.ts
View File

@ -150,6 +150,17 @@ export class ReleaseTool {
*/ */
private async _verifyNpmLoginState(): Promise<boolean> { private async _verifyNpmLoginState(): Promise<boolean> {
const registry = `NPM at the ${this._config.publishRegistry ?? 'default NPM'} registry`; const registry = `NPM at the ${this._config.publishRegistry ?? 'default NPM'} registry`;
// TODO(josephperrott): remove wombat specific block once wombot allows `npm whoami` check to
// check the status of the local token in the .npmrc file.
if (this._config.publishRegistry?.includes('wombat-dressing-room.appspot.com')) {
info('Unable to determine NPM login state for wombat proxy, requiring login now.');
try {
await npmLogin(this._config.publishRegistry);
} catch {
return false;
}
return true;
}
if (await npmIsLoggedIn(this._config.publishRegistry)) { if (await npmIsLoggedIn(this._config.publishRegistry)) {
debug(`Already logged into ${registry}.`); debug(`Already logged into ${registry}.`);
return true; return true;