honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(language-service): refactor the method TypeWrapper.name and PipeSymbol.selectSignature (#34177)

Browse Source 
PR Close #34177
This commit is contained in:
ivanwonder 2019-12-04 14:09:48 +08:00 committed by Andrew Kushnir
parent 7a86a32040
commit a91ca99b1f
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/language-service/src/typescript_symbols.ts
View File

@ -244,16 +244,7 @@ class TypeWrapper implements Symbol {
}
}
get name(): string {
const symbol = this.tsType.symbol;
if (symbol) {
return symbol.name;
} else {
// A primitive type (e.g. 'string') doesn't have Symbol,
// so use the ts.TypeChecker to get the type name.
return this.context.checker.typeToString(this.tsType);
}
}
get name(): string { return this.context.checker.typeToString(this.tsType); }
public readonly kind: DeclarationKind = 'type';
@ -617,15 +608,10 @@ class PipeSymbol implements Symbol {
let resultType: ts.Type|undefined = undefined;
switch (this.name) {
case 'async':
switch (parameterType.name) {
case 'Observable':
case 'Promise':
case 'EventEmitter':
resultType = getTypeParameterOf(parameterType.tsType, parameterType.name);
break;
default:
resultType = getTsTypeFromBuiltinType(BuiltinType.Any, this.context);
break;
// Get symbol of 'Observable', 'Promise', or 'EventEmitter' type.
const symbol = parameterType.tsType.symbol;
if (symbol) {
resultType = getTypeParameterOf(parameterType.tsType, symbol.name);
}
break;
case 'slice':