honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: run browsers tests on chromium locally (#38435) 

Previously we added a browser target for `firefox` into the
dev-infra package. It looks like as part of this change, we
accidentally switched the local web testing target to `firefox`.

Web tests are not commonly run locally as we use Domino and
NodeJS tests for primary development. Sometimes though we intend
to run tests in a browser. This would currently work with Firefox
but not on Windows (as Firefox is a noop there in Bazel).

This commit switches the primary browser back to `chromium`. Also
Firefox has been added as a second browser to web testing targets.

This allows us to reduce browsers in the legacy Saucelabs job. i.e.
not running Chrome and Firefox there. This should increase stability
and speed up the legacy job (+ reduced rate limit for Saucelabs).

PR Close #38435
This commit is contained in:
Paul Gschwendtner 2020-08-13 10:09:43 +02:00 committed by Andrew Scott
parent 8763d8201c
commit aa847cb014
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browser-providers.conf.js
View File

@ -12,8 +12,10 @@
// If a category becomes empty (e.g. BS and required), then the corresponding job must be commented // If a category becomes empty (e.g. BS and required), then the corresponding job must be commented
// out in the CI configuration. // out in the CI configuration.
var CIconfiguration = { var CIconfiguration = {
'Chrome': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}}, // Chrome and Firefox run as part of the Bazel browser tests, so we do not run them as
'Firefox': {unitTest: {target: 'SL', required: true}, e2e: {target: null, required: true}}, // part of the legacy Saucelabs tests.
'Chrome': {unitTest: {target: null, required: false}, e2e: {target: null, required: true}},
'Firefox': {unitTest: {target: null, required: false}, e2e: {target: null, required: true}},
// Set ESR as a not required browser as it fails for Ivy acceptance tests. // Set ESR as a not required browser as it fails for Ivy acceptance tests.
'FirefoxESR': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: true}}, 'FirefoxESR': {unitTest: {target: 'SL', required: false}, e2e: {target: null, required: true}},
// Disabled because using the "beta" channel of Chrome can cause non-deterministic CI results. // Disabled because using the "beta" channel of Chrome can cause non-deterministic CI results.

5
tools/defaults.bzl
View File

@ -245,7 +245,10 @@ def karma_web_test_suite(name, **kwargs):
runtime_deps = runtime_deps, runtime_deps = runtime_deps,
bootstrap = bootstrap, bootstrap = bootstrap,
deps = deps, deps = deps,
browsers = ["//dev-infra/browsers/firefox:firefox"], browsers = [
"//dev-infra/browsers/chromium:chromium",
"//dev-infra/browsers/firefox:firefox",
],
data = data, data = data,
tags = tags, tags = tags,
**kwargs **kwargs