honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: stop execution on error in `validate-commit-message` (#28780) 

Stop execution when an error happens in `validate-commit-message` gulp
task and ensure the error message is printed at the bottom.

Fixes #16829

PR Close #28780
This commit is contained in:
George Kalpakas 2019-02-17 10:57:31 +02:00 committed by Igor Minar
parent af8d58cb51
commit ababc5b4a4
1 changed files with 37 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/gulp-tasks/validate-commit-message.js
View File

@ -9,13 +9,17 @@
// tslint:disable:no-console // tslint:disable:no-console
module.exports = (gulp) => () => { module.exports = (gulp) => () => {
try {
const validateCommitMessage = require('../validate-commit-message'); const validateCommitMessage = require('../validate-commit-message');
const shelljs = require('shelljs'); const shelljs = require('shelljs');
shelljs.set('-e'); // Break on error.
let baseBranch = 'master'; let baseBranch = 'master';
const currentVersion = require('semver').parse(require('../../package.json').version); const currentVersion = require('semver').parse(require('../../package.json').version);
const baseHead = const baseHead =
shelljs.exec(`git ls-remote --heads origin ${currentVersion.major}.${currentVersion.minor}.*`) shelljs
.exec(`git ls-remote --heads origin ${currentVersion.major}.${currentVersion.minor}.*`)
.trim() .trim()
.split('\n') .split('\n')
.pop(); .pop();
@ -26,12 +30,11 @@ module.exports = (gulp) => () => {
// We need to fetch origin explicitly because it might be stale. // We need to fetch origin explicitly because it might be stale.
// I couldn't find a reliable way to do this without fetch. // I couldn't find a reliable way to do this without fetch.
result = shelljs.exec( const result = shelljs.exec(
`git fetch origin ${baseBranch} && git log --reverse --format=%s HEAD ^origin/${baseBranch}`); `git fetch origin ${baseBranch} && git log --reverse --format=%s HEAD ^origin/${baseBranch}`);
if (result.code) { if (result.code) {
console.log(result.stderr); throw new Error(`Failed to fetch commits: ${result.stderr}`);
process.exit(1);
} }
const commitsByLine = result.trim().split(/\n/).filter(line => line != ''); const commitsByLine = result.trim().split(/\n/).filter(line => line != '');
@ -45,9 +48,12 @@ module.exports = (gulp) => () => {
const someCommitsInvalid = !commitsByLine.every(validateCommitMessage); const someCommitsInvalid = !commitsByLine.every(validateCommitMessage);
if (someCommitsInvalid) { if (someCommitsInvalid) {
console.log('Please fix the failing commit messages before continuing...'); throw new Error(
console.log( 'Please fix the failing commit messages before continuing...\n' +
'Commit message guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines'); 'Commit message guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines');
}
} catch (err) {
console.error(err);
process.exit(1); process.exit(1);
} }
}; };