honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: remove toplevel property accesses (#29329) 

PR Close #29329
This commit is contained in:
Filipe Silva 2019-05-02 16:44:24 +01:00 committed by Jason Aden
parent 739e5a4f53
commit ac34a1429b
32 changed files with 231 additions and 253 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
integration/_payload-limits.json
View File

@ -3,7 +3,7 @@
"master": { "master": {
"uncompressed": { "uncompressed": {
"runtime": 1497, "runtime": 1497,
"main": 164945, "main": 166739,
"polyfills": 43626 "polyfills": 43626
} }
} }

11
integration/side-effects/snapshots/animations-browser/esm2015.js
View File

@ -1,14 +1,3 @@
import "@angular/animations"; import "@angular/animations";
import "@angular/core"; import "@angular/core";
function isNode() {
return "undefined" !== typeof process;
}
const _isNode = isNode();
if (_isNode || "undefined" !== typeof Element) if (_isNode || Element.prototype.matches) ; else {
const proto = Element.prototype;
const fn = proto.matchesSelector || proto.mozMatchesSelector || proto.msMatchesSelector || proto.oMatchesSelector || proto.webkitMatchesSelector;
}

11
integration/side-effects/snapshots/animations-browser/esm5.js
View File

@ -3,14 +3,3 @@ import "tslib";
import "@angular/animations"; import "@angular/animations";
import "@angular/core"; import "@angular/core";
function isNode() {
return "undefined" !== typeof process;
}
var _isNode = isNode();
if (_isNode || "undefined" !== typeof Element) if (_isNode || Element.prototype.matches) ; else {
var proto = Element.prototype;
var fn_1 = proto.matchesSelector || proto.mozMatchesSelector || proto.msMatchesSelector || proto.oMatchesSelector || proto.webkitMatchesSelector;
}

4
integration/side-effects/snapshots/elements/esm2015.js
View File

@ -3,7 +3,3 @@ import "@angular/core";
import "rxjs"; import "rxjs";
import "rxjs/operators"; import "rxjs/operators";
const elProto = Element.prototype;
const matches = elProto.matches || elProto.matchesSelector || elProto.mozMatchesSelector || elProto.msMatchesSelector || elProto.oMatchesSelector || elProto.webkitMatchesSelector;

4
integration/side-effects/snapshots/elements/esm5.js
View File

@ -5,7 +5,3 @@ import "@angular/core";
import "rxjs"; import "rxjs";
import "rxjs/operators"; import "rxjs/operators";
var elProto = Element.prototype;
var matches = elProto.matches || elProto.matchesSelector || elProto.mozMatchesSelector || elProto.msMatchesSelector || elProto.oMatchesSelector || elProto.webkitMatchesSelector;

16
integration/side-effects/snapshots/platform-browser/esm2015.js
View File

@ -1,17 +1,3 @@
import "@angular/common"; import "@angular/common";
import { ɵglobal } from "@angular/core"; import "@angular/core";
let nodeContains;
if (ɵglobal["Node"]) nodeContains = ɵglobal["Node"].prototype.contains || function(node) {
return !!(16 & this.compareDocumentPosition(node));
};
const ɵ0 = function(v) {
return "__zone_symbol__" + v;
};
const __symbol__ = "undefined" !== typeof Zone && Zone["__symbol__"] || ɵ0;
const blackListedEvents = "undefined" !== typeof Zone && Zone[__symbol__("BLACK_LISTED_EVENTS")];

16
integration/side-effects/snapshots/platform-browser/esm5.js
View File

@ -2,18 +2,4 @@ import "tslib";
import "@angular/common"; import "@angular/common";
import { ɵglobal } from "@angular/core"; import "@angular/core";
var nodeContains;
if (ɵglobal["Node"]) nodeContains = ɵglobal["Node"].prototype.contains || function(node) {
return !!(16 & this.compareDocumentPosition(node));
};
var ɵ0 = function(v) {
return "__zone_symbol__" + v;
};
var __symbol__ = "undefined" !== typeof Zone && Zone["__symbol__"] || ɵ0;
var blackListedEvents = "undefined" !== typeof Zone && Zone[__symbol__("BLACK_LISTED_EVENTS")];

1
package.json
View File

@ -155,6 +155,7 @@
"sauce-connect": "https://saucelabs.com/downloads/sc-4.5.1-linux.tar.gz", "sauce-connect": "https://saucelabs.com/downloads/sc-4.5.1-linux.tar.gz",
"semver": "5.4.1", "semver": "5.4.1",
"tslint-eslint-rules": "4.1.1", "tslint-eslint-rules": "4.1.1",
"tslint-no-toplevel-property-access": "0.0.2",
"tsutils": "2.27.2", "tsutils": "2.27.2",
"universal-analytics": "0.4.15", "universal-analytics": "0.4.15",
"vlq": "0.2.2", "vlq": "0.2.2",

7
packages/animations/browser/src/dsl/style_normalization/web_animations_style_normalizer.ts
View File

@ -34,9 +34,10 @@ export class WebAnimationsStyleNormalizer extends AnimationStyleNormalizer {
} }
} }
const DIMENSIONAL_PROP_MAP = makeBooleanMap( const DIMENSIONAL_PROP_MAP =
'width,height,minWidth,minHeight,maxWidth,maxHeight,left,top,bottom,right,fontSize,outlineWidth,outlineOffset,paddingTop,paddingLeft,paddingBottom,paddingRight,marginTop,marginLeft,marginBottom,marginRight,borderRadius,borderWidth,borderTopWidth,borderLeftWidth,borderRightWidth,borderBottomWidth,textIndent,perspective' (() => makeBooleanMap(
.split(',')); 'width,height,minWidth,minHeight,maxWidth,maxHeight,left,top,bottom,right,fontSize,outlineWidth,outlineOffset,paddingTop,paddingLeft,paddingBottom,paddingRight,marginTop,marginLeft,marginBottom,marginRight,borderRadius,borderWidth,borderTopWidth,borderLeftWidth,borderRightWidth,borderBottomWidth,textIndent,perspective'
.split(',')))();
function makeBooleanMap(keys: string[]): {[key: string]: boolean} { function makeBooleanMap(keys: string[]): {[key: string]: boolean} {
const map: {[key: string]: boolean} = {}; const map: {[key: string]: boolean} = {};

22
packages/animations/browser/src/render/shared.ts
View File

@ -158,16 +158,20 @@ if (_isNode || typeof Element !== 'undefined') {
// this is well supported in all browsers // this is well supported in all browsers
_contains = (elm1: any, elm2: any) => { return elm1.contains(elm2) as boolean; }; _contains = (elm1: any, elm2: any) => { return elm1.contains(elm2) as boolean; };
if (_isNode || Element.prototype.matches) { _matches = (() => {
_matches = (element: any, selector: string) => element.matches(selector); if (_isNode || Element.prototype.matches) {
} else { return (element: any, selector: string) => element.matches(selector);
const proto = Element.prototype as any; } else {
const fn = proto.matchesSelector || proto.mozMatchesSelector || proto.msMatchesSelector || const proto = Element.prototype as any;
proto.oMatchesSelector || proto.webkitMatchesSelector; const fn = proto.matchesSelector || proto.mozMatchesSelector || proto.msMatchesSelector ||
if (fn) { proto.oMatchesSelector || proto.webkitMatchesSelector;
_matches = (element: any, selector: string) => fn.apply(element, [selector]); if (fn) {
return (element: any, selector: string) => fn.apply(element, [selector]);
} else {
return _matches;
}
} }
} })();
_query = (element: any, selector: string, multi: boolean): any[] => { _query = (element: any, selector: string, multi: boolean): any[] => {
let results: any[] = []; let results: any[] = [];

5
packages/core/src/di/injector.ts
View File

@ -117,7 +117,6 @@ const enum OptionFlags {
CheckParent = 1 << 2, CheckParent = 1 << 2,
Default = CheckSelf | CheckParent Default = CheckSelf | CheckParent
} }
const NULL_INJECTOR = Injector.NULL;
const NO_NEW_LINE = 'ɵ'; const NO_NEW_LINE = 'ɵ';
export class StaticInjector implements Injector { export class StaticInjector implements Injector {
@ -127,7 +126,7 @@ export class StaticInjector implements Injector {
private _records: Map<any, Record>; private _records: Map<any, Record>;
constructor( constructor(
providers: StaticProvider[], parent: Injector = NULL_INJECTOR, source: string|null = null) { providers: StaticProvider[], parent: Injector = Injector.NULL, source: string|null = null) {
this.parent = parent; this.parent = parent;
this.source = source; this.source = source;
const records = this._records = new Map<any, Record>(); const records = this._records = new Map<any, Record>();
@ -304,7 +303,7 @@ function resolveToken(
records, records,
// If we don't know how to resolve dependency and we should not check parent for it, // If we don't know how to resolve dependency and we should not check parent for it,
// than pass in Null injector. // than pass in Null injector.
!childRecord && !(options & OptionFlags.CheckParent) ? NULL_INJECTOR : parent, !childRecord && !(options & OptionFlags.CheckParent) ? Injector.NULL : parent,
options & OptionFlags.Optional ? null : Injector.THROW_IF_NOT_FOUND, options & OptionFlags.Optional ? null : Injector.THROW_IF_NOT_FOUND,
InjectFlags.Default)); InjectFlags.Default));
} }

4
packages/core/src/render3/empty.ts
View File

@ -19,6 +19,10 @@ export const EMPTY_ARRAY: any[] = [];
// freezing the values prevents any code from accidentally inserting new values in // freezing the values prevents any code from accidentally inserting new values in
if (typeof ngDevMode !== 'undefined' && ngDevMode) { if (typeof ngDevMode !== 'undefined' && ngDevMode) {
// These property accesses can be ignored because ngDevMode will be set to false
// when optimizing code and the whole if statement will be dropped.
// tslint:disable-next-line:no-toplevel-property-access
Object.freeze(EMPTY_OBJ); Object.freeze(EMPTY_OBJ);
// tslint:disable-next-line:no-toplevel-property-access
Object.freeze(EMPTY_ARRAY); Object.freeze(EMPTY_ARRAY);
} }

2
packages/core/src/render3/instructions/shared.ts
View File

@ -45,7 +45,7 @@ import {getComponentViewByIndex, getNativeByIndex, getNativeByTNode, getTNode, i
* A permanent marker promise which signifies that the current CD tree is * A permanent marker promise which signifies that the current CD tree is
* clean. * clean.
*/ */
const _CLEAN_PROMISE = Promise.resolve(null); const _CLEAN_PROMISE = (() => Promise.resolve(null))();
export const enum BindingDirection { export const enum BindingDirection {
Input, Input,

4
packages/core/src/render3/interfaces/injector.ts
View File

@ -241,10 +241,10 @@ export class NodeInjectorFactory {
} }
} }
const FactoryPrototype = NodeInjectorFactory.prototype;
export function isFactory(obj: any): obj is NodeInjectorFactory { export function isFactory(obj: any): obj is NodeInjectorFactory {
// See: https://jsperf.com/instanceof-vs-getprototypeof // See: https://jsperf.com/instanceof-vs-getprototypeof
return obj !== null && typeof obj == 'object' && Object.getPrototypeOf(obj) == FactoryPrototype; return obj !== null && typeof obj == 'object' &&
Object.getPrototypeOf(obj) == NodeInjectorFactory.prototype;
} }
// Note: This hack is necessary so we don't erroneously get a circular dependency // Note: This hack is necessary so we don't erroneously get a circular dependency

243
packages/core/src/render3/jit/environment.ts
View File

@ -17,125 +17,126 @@ import * as sanitization from '../../sanitization/sanitization';
* *
* This should be kept up to date with the public exports of @angular/core. * This should be kept up to date with the public exports of @angular/core.
*/ */
export const angularCoreEnv: {[name: string]: Function} = { export const angularCoreEnv: {[name: string]: Function} =
'ΔdefineBase': r3.ΔdefineBase, (() => ({
'ΔdefineComponent': r3.ΔdefineComponent, 'ΔdefineBase': r3.ΔdefineBase,
'ΔdefineDirective': r3.ΔdefineDirective, 'ΔdefineComponent': r3.ΔdefineComponent,
'ΔdefineInjectable': ΔdefineInjectable, 'ΔdefineDirective': r3.ΔdefineDirective,
'ΔdefineInjector': ΔdefineInjector, 'ΔdefineInjectable': ΔdefineInjectable,
'ΔdefineNgModule': r3.ΔdefineNgModule, 'ΔdefineInjector': ΔdefineInjector,
'ΔdefinePipe': r3.ΔdefinePipe, 'ΔdefineNgModule': r3.ΔdefineNgModule,
'ΔdirectiveInject': r3.ΔdirectiveInject, 'ΔdefinePipe': r3.ΔdefinePipe,
'ΔgetFactoryOf': r3.ΔgetFactoryOf, 'ΔdirectiveInject': r3.ΔdirectiveInject,
'ΔgetInheritedFactory': r3.ΔgetInheritedFactory, 'ΔgetFactoryOf': r3.ΔgetFactoryOf,
'Δinject': Δinject, 'ΔgetInheritedFactory': r3.ΔgetInheritedFactory,
'ΔinjectAttribute': r3.ΔinjectAttribute, 'Δinject': Δinject,
'ΔtemplateRefExtractor': r3.ΔtemplateRefExtractor, 'ΔinjectAttribute': r3.ΔinjectAttribute,
'ΔNgOnChangesFeature': r3.ΔNgOnChangesFeature, 'ΔtemplateRefExtractor': r3.ΔtemplateRefExtractor,
'ΔProvidersFeature': r3.ΔProvidersFeature, 'ΔNgOnChangesFeature': r3.ΔNgOnChangesFeature,
'ΔInheritDefinitionFeature': r3.ΔInheritDefinitionFeature, 'ΔProvidersFeature': r3.ΔProvidersFeature,
'ΔelementAttribute': r3.ΔelementAttribute, 'ΔInheritDefinitionFeature': r3.ΔInheritDefinitionFeature,
'Δbind': r3.Δbind, 'ΔelementAttribute': r3.ΔelementAttribute,
'Δcontainer': r3.Δcontainer, 'Δbind': r3.Δbind,
'ΔnextContext': r3.ΔnextContext, 'Δcontainer': r3.Δcontainer,
'ΔcontainerRefreshStart': r3.ΔcontainerRefreshStart, 'ΔnextContext': r3.ΔnextContext,
'ΔcontainerRefreshEnd': r3.ΔcontainerRefreshEnd, 'ΔcontainerRefreshStart': r3.ΔcontainerRefreshStart,
'ΔnamespaceHTML': r3.ΔnamespaceHTML, 'ΔcontainerRefreshEnd': r3.ΔcontainerRefreshEnd,
'ΔnamespaceMathML': r3.ΔnamespaceMathML, 'ΔnamespaceHTML': r3.ΔnamespaceHTML,
'ΔnamespaceSVG': r3.ΔnamespaceSVG, 'ΔnamespaceMathML': r3.ΔnamespaceMathML,
'ΔenableBindings': r3.ΔenableBindings, 'ΔnamespaceSVG': r3.ΔnamespaceSVG,
'ΔdisableBindings': r3.ΔdisableBindings, 'ΔenableBindings': r3.ΔenableBindings,
'ΔallocHostVars': r3.ΔallocHostVars, 'ΔdisableBindings': r3.ΔdisableBindings,
'ΔelementStart': r3.ΔelementStart, 'ΔallocHostVars': r3.ΔallocHostVars,
'ΔelementEnd': r3.ΔelementEnd, 'ΔelementStart': r3.ΔelementStart,
'Δelement': r3.Δelement, 'ΔelementEnd': r3.ΔelementEnd,
'ΔelementContainerStart': r3.ΔelementContainerStart, 'Δelement': r3.Δelement,
'ΔelementContainerEnd': r3.ΔelementContainerEnd, 'ΔelementContainerStart': r3.ΔelementContainerStart,
'ΔpureFunction0': r3.ΔpureFunction0, 'ΔelementContainerEnd': r3.ΔelementContainerEnd,
'ΔpureFunction1': r3.ΔpureFunction1, 'ΔpureFunction0': r3.ΔpureFunction0,
'ΔpureFunction2': r3.ΔpureFunction2, 'ΔpureFunction1': r3.ΔpureFunction1,
'ΔpureFunction3': r3.ΔpureFunction3, 'ΔpureFunction2': r3.ΔpureFunction2,
'ΔpureFunction4': r3.ΔpureFunction4, 'ΔpureFunction3': r3.ΔpureFunction3,
'ΔpureFunction5': r3.ΔpureFunction5, 'ΔpureFunction4': r3.ΔpureFunction4,
'ΔpureFunction6': r3.ΔpureFunction6, 'ΔpureFunction5': r3.ΔpureFunction5,
'ΔpureFunction7': r3.ΔpureFunction7, 'ΔpureFunction6': r3.ΔpureFunction6,
'ΔpureFunction8': r3.ΔpureFunction8, 'ΔpureFunction7': r3.ΔpureFunction7,
'ΔpureFunctionV': r3.ΔpureFunctionV, 'ΔpureFunction8': r3.ΔpureFunction8,
'ΔgetCurrentView': r3.ΔgetCurrentView, 'ΔpureFunctionV': r3.ΔpureFunctionV,
'ΔrestoreView': r3.ΔrestoreView, 'ΔgetCurrentView': r3.ΔgetCurrentView,
'Δinterpolation1': r3.Δinterpolation1, 'ΔrestoreView': r3.ΔrestoreView,
'Δinterpolation2': r3.Δinterpolation2, 'Δinterpolation1': r3.Δinterpolation1,
'Δinterpolation3': r3.Δinterpolation3, 'Δinterpolation2': r3.Δinterpolation2,
'Δinterpolation4': r3.Δinterpolation4, 'Δinterpolation3': r3.Δinterpolation3,
'Δinterpolation5': r3.Δinterpolation5, 'Δinterpolation4': r3.Δinterpolation4,
'Δinterpolation6': r3.Δinterpolation6, 'Δinterpolation5': r3.Δinterpolation5,
'Δinterpolation7': r3.Δinterpolation7, 'Δinterpolation6': r3.Δinterpolation6,
'Δinterpolation8': r3.Δinterpolation8, 'Δinterpolation7': r3.Δinterpolation7,
'ΔinterpolationV': r3.ΔinterpolationV, 'Δinterpolation8': r3.Δinterpolation8,
'Δlistener': r3.Δlistener, 'ΔinterpolationV': r3.ΔinterpolationV,
'Δload': r3.Δload, 'Δlistener': r3.Δlistener,
'Δprojection': r3.Δprojection, 'Δload': r3.Δload,
'ΔelementProperty': r3.ΔelementProperty, 'Δprojection': r3.Δprojection,
'ΔcomponentHostSyntheticProperty': r3.ΔcomponentHostSyntheticProperty, 'ΔelementProperty': r3.ΔelementProperty,
'ΔcomponentHostSyntheticListener': r3.ΔcomponentHostSyntheticListener, 'ΔcomponentHostSyntheticProperty': r3.ΔcomponentHostSyntheticProperty,
'ΔpipeBind1': r3.ΔpipeBind1, 'ΔcomponentHostSyntheticListener': r3.ΔcomponentHostSyntheticListener,
'ΔpipeBind2': r3.ΔpipeBind2, 'ΔpipeBind1': r3.ΔpipeBind1,
'ΔpipeBind3': r3.ΔpipeBind3, 'ΔpipeBind2': r3.ΔpipeBind2,
'ΔpipeBind4': r3.ΔpipeBind4, 'ΔpipeBind3': r3.ΔpipeBind3,
'ΔpipeBindV': r3.ΔpipeBindV, 'ΔpipeBind4': r3.ΔpipeBind4,
'ΔprojectionDef': r3.ΔprojectionDef, 'ΔpipeBindV': r3.ΔpipeBindV,
'Δproperty': r3.Δproperty, 'ΔprojectionDef': r3.ΔprojectionDef,
'ΔpropertyInterpolate': r3.ΔpropertyInterpolate, 'Δproperty': r3.Δproperty,
'ΔpropertyInterpolate1': r3.ΔpropertyInterpolate1, 'ΔpropertyInterpolate': r3.ΔpropertyInterpolate,
'ΔpropertyInterpolate2': r3.ΔpropertyInterpolate2, 'ΔpropertyInterpolate1': r3.ΔpropertyInterpolate1,
'ΔpropertyInterpolate3': r3.ΔpropertyInterpolate3, 'ΔpropertyInterpolate2': r3.ΔpropertyInterpolate2,
'ΔpropertyInterpolate4': r3.ΔpropertyInterpolate4, 'ΔpropertyInterpolate3': r3.ΔpropertyInterpolate3,
'ΔpropertyInterpolate5': r3.ΔpropertyInterpolate5, 'ΔpropertyInterpolate4': r3.ΔpropertyInterpolate4,
'ΔpropertyInterpolate6': r3.ΔpropertyInterpolate6, 'ΔpropertyInterpolate5': r3.ΔpropertyInterpolate5,
'ΔpropertyInterpolate7': r3.ΔpropertyInterpolate7, 'ΔpropertyInterpolate6': r3.ΔpropertyInterpolate6,
'ΔpropertyInterpolate8': r3.ΔpropertyInterpolate8, 'ΔpropertyInterpolate7': r3.ΔpropertyInterpolate7,
'ΔpropertyInterpolateV': r3.ΔpropertyInterpolateV, 'ΔpropertyInterpolate8': r3.ΔpropertyInterpolate8,
'Δpipe': r3.Δpipe, 'ΔpropertyInterpolateV': r3.ΔpropertyInterpolateV,
'ΔqueryRefresh': r3.ΔqueryRefresh, 'Δpipe': r3.Δpipe,
'ΔviewQuery': r3.ΔviewQuery, 'ΔqueryRefresh': r3.ΔqueryRefresh,
'ΔstaticViewQuery': r3.ΔstaticViewQuery, 'ΔviewQuery': r3.ΔviewQuery,
'ΔstaticContentQuery': r3.ΔstaticContentQuery, 'ΔstaticViewQuery': r3.ΔstaticViewQuery,
'ΔloadViewQuery': r3.ΔloadViewQuery, 'ΔstaticContentQuery': r3.ΔstaticContentQuery,
'ΔcontentQuery': r3.ΔcontentQuery, 'ΔloadViewQuery': r3.ΔloadViewQuery,
'ΔloadContentQuery': r3.ΔloadContentQuery, 'ΔcontentQuery': r3.ΔcontentQuery,
'Δreference': r3.Δreference, 'ΔloadContentQuery': r3.ΔloadContentQuery,
'ΔelementHostAttrs': r3.ΔelementHostAttrs, 'Δreference': r3.Δreference,
'ΔclassMap': r3.ΔclassMap, 'ΔelementHostAttrs': r3.ΔelementHostAttrs,
'Δstyling': r3.Δstyling, 'ΔclassMap': r3.ΔclassMap,
'ΔstyleMap': r3.ΔstyleMap, 'Δstyling': r3.Δstyling,
'ΔstyleProp': r3.ΔstyleProp, 'ΔstyleMap': r3.ΔstyleMap,
'ΔstylingApply': r3.ΔstylingApply, 'ΔstyleProp': r3.ΔstyleProp,
'ΔclassProp': r3.ΔclassProp, 'ΔstylingApply': r3.ΔstylingApply,
'Δselect': r3.Δselect, 'ΔclassProp': r3.ΔclassProp,
'Δtemplate': r3.Δtemplate, 'Δselect': r3.Δselect,
'Δtext': r3.Δtext, 'Δtemplate': r3.Δtemplate,
'ΔtextBinding': r3.ΔtextBinding, 'Δtext': r3.Δtext,
'ΔembeddedViewStart': r3.ΔembeddedViewStart, 'ΔtextBinding': r3.ΔtextBinding,
'ΔembeddedViewEnd': r3.ΔembeddedViewEnd, 'ΔembeddedViewStart': r3.ΔembeddedViewStart,
'Δi18n': r3.Δi18n, 'ΔembeddedViewEnd': r3.ΔembeddedViewEnd,
'Δi18nAttributes': r3.Δi18nAttributes, 'Δi18n': r3.Δi18n,
'Δi18nExp': r3.Δi18nExp, 'Δi18nAttributes': r3.Δi18nAttributes,
'Δi18nStart': r3.Δi18nStart, 'Δi18nExp': r3.Δi18nExp,
'Δi18nEnd': r3.Δi18nEnd, 'Δi18nStart': r3.Δi18nStart,
'Δi18nApply': r3.Δi18nApply, 'Δi18nEnd': r3.Δi18nEnd,
'Δi18nPostprocess': r3.Δi18nPostprocess, 'Δi18nApply': r3.Δi18nApply,
'Δi18nLocalize': r3.Δi18nLocalize, 'Δi18nPostprocess': r3.Δi18nPostprocess,
'ΔresolveWindow': r3.ΔresolveWindow, 'Δi18nLocalize': r3.Δi18nLocalize,
'ΔresolveDocument': r3.ΔresolveDocument, 'ΔresolveWindow': r3.ΔresolveWindow,
'ΔresolveBody': r3.ΔresolveBody, 'ΔresolveDocument': r3.ΔresolveDocument,
'ΔsetComponentScope': r3.ΔsetComponentScope, 'ΔresolveBody': r3.ΔresolveBody,
'ΔsetNgModuleScope': r3.ΔsetNgModuleScope, 'ΔsetComponentScope': r3.ΔsetComponentScope,
'ΔsetNgModuleScope': r3.ΔsetNgModuleScope,
'ΔsanitizeHtml': sanitization.ΔsanitizeHtml, 'ΔsanitizeHtml': sanitization.ΔsanitizeHtml,
'ΔsanitizeStyle': sanitization.ΔsanitizeStyle, 'ΔsanitizeStyle': sanitization.ΔsanitizeStyle,
'ΔdefaultStyleSanitizer': sanitization.ΔdefaultStyleSanitizer, 'ΔdefaultStyleSanitizer': sanitization.ΔdefaultStyleSanitizer,
'ΔsanitizeResourceUrl': sanitization.ΔsanitizeResourceUrl, 'ΔsanitizeResourceUrl': sanitization.ΔsanitizeResourceUrl,
'ΔsanitizeScript': sanitization.ΔsanitizeScript, 'ΔsanitizeScript': sanitization.ΔsanitizeScript,
'ΔsanitizeUrl': sanitization.ΔsanitizeUrl, 'ΔsanitizeUrl': sanitization.ΔsanitizeUrl,
'ΔsanitizeUrlOrResourceUrl': sanitization.ΔsanitizeUrlOrResourceUrl, 'ΔsanitizeUrlOrResourceUrl': sanitization.ΔsanitizeUrlOrResourceUrl,
}; }))();

7
packages/core/src/render3/util/misc_utils.ts
View File

@ -48,9 +48,10 @@ export function stringifyForError(value: any) {
export const defaultScheduler = export const defaultScheduler =
(typeof requestAnimationFrame !== 'undefined' && requestAnimationFrame || // browser only (() =>
setTimeout // everything else (typeof requestAnimationFrame !== 'undefined' && requestAnimationFrame || // browser only
).bind(global); setTimeout // everything else
).bind(global))();
/** /**
* *

4
packages/core/src/util/empty.ts
View File

@ -19,6 +19,10 @@ export const EMPTY_ARRAY: any[] = [];
// freezing the values prevents any code from accidentally inserting new values in // freezing the values prevents any code from accidentally inserting new values in
if (typeof ngDevMode !== 'undefined' && ngDevMode) { if (typeof ngDevMode !== 'undefined' && ngDevMode) {
// These property accesses can be ignored because ngDevMode will be set to false
// when optimizing code and the whole if statement will be dropped.
// tslint:disable-next-line:no-toplevel-property-access
Object.freeze(EMPTY_OBJ); Object.freeze(EMPTY_OBJ);
// tslint:disable-next-line:no-toplevel-property-access
Object.freeze(EMPTY_ARRAY); Object.freeze(EMPTY_ARRAY);
} }

3
packages/core/src/util/microtask.ts
View File

@ -6,8 +6,7 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
const promise: Promise<any> = (() => Promise.resolve(0))();
const promise: Promise<any> = Promise.resolve(0);
declare const Zone: any; declare const Zone: any;

4
packages/core/src/util/ng_i18n_closure_mode.ts
View File

@ -16,8 +16,12 @@ declare global {
* NOTE: changes to the `ngI18nClosureMode` name must be synced with `compiler-cli/src/tooling.ts`. * NOTE: changes to the `ngI18nClosureMode` name must be synced with `compiler-cli/src/tooling.ts`.
*/ */
if (typeof ngI18nClosureMode === 'undefined') { if (typeof ngI18nClosureMode === 'undefined') {
// These property accesses can be ignored because ngI18nClosureMode will be set to false
// when optimizing code and the whole if statement will be dropped.
// Make sure to refer to ngI18nClosureMode as ['ngI18nClosureMode'] for closure. // Make sure to refer to ngI18nClosureMode as ['ngI18nClosureMode'] for closure.
// tslint:disable-next-line:no-toplevel-property-access
global['ngI18nClosureMode'] = global['ngI18nClosureMode'] =
// TODO(FW-1250): validate that this actually, you know, works. // TODO(FW-1250): validate that this actually, you know, works.
// tslint:disable-next-line:no-toplevel-property-access
typeof goog !== 'undefined' && typeof goog.getMsg === 'function'; typeof goog !== 'undefined' && typeof goog.getMsg === 'function';
} }

3
packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
View File

@ -50,9 +50,6 @@
{ {
"name": "FLAGS" "name": "FLAGS"
}, },
{
"name": "FactoryPrototype"
},
{ {
"name": "HEADER_OFFSET" "name": "HEADER_OFFSET"
}, },

3
packages/core/test/bundling/hello_world/bundle.golden_symbols.json
View File

@ -41,9 +41,6 @@
{ {
"name": "FLAGS" "name": "FLAGS"
}, },
{
"name": "FactoryPrototype"
},
{ {
"name": "HEADER_OFFSET" "name": "HEADER_OFFSET"
}, },

3
packages/core/test/bundling/todo/bundle.golden_symbols.json
View File

@ -83,9 +83,6 @@
{ {
"name": "FLAGS" "name": "FLAGS"
}, },
{
"name": "FactoryPrototype"
},
{ {
"name": "HEADER_OFFSET" "name": "HEADER_OFFSET"
}, },

8
packages/elements/src/utils.ts
View File

@ -7,9 +7,11 @@
*/ */
import {ComponentFactoryResolver, Injector, Type} from '@angular/core'; import {ComponentFactoryResolver, Injector, Type} from '@angular/core';
const elProto = Element.prototype as any; const matches = (() => {
const matches = elProto.matches || elProto.matchesSelector || elProto.mozMatchesSelector || const elProto = Element.prototype as any;
elProto.msMatchesSelector || elProto.oMatchesSelector || elProto.webkitMatchesSelector; return elProto.matches || elProto.matchesSelector || elProto.mozMatchesSelector ||
elProto.msMatchesSelector || elProto.oMatchesSelector || elProto.webkitMatchesSelector;
})();
/** /**
* Provide methods for scheduling the execution of a callback. * Provide methods for scheduling the execution of a callback.

2
packages/forms/src/directives/ng_form.ts
View File

@ -23,7 +23,7 @@ export const formDirectiveProvider: any = {
useExisting: forwardRef(() => NgForm) useExisting: forwardRef(() => NgForm)
}; };
const resolvedPromise = Promise.resolve(null); const resolvedPromise = (() => Promise.resolve(null))();
/** /**
* @description * @description

2
packages/forms/src/directives/ng_model.ts
View File

@ -43,7 +43,7 @@ export const formControlBinding: any = {
* - this is just one extra run no matter how many `ngModel` have been changed. * - this is just one extra run no matter how many `ngModel` have been changed.
* - this is a general problem when using `exportAs` for directives! * - this is a general problem when using `exportAs` for directives!
*/ */
const resolvedPromise = Promise.resolve(null); const resolvedPromise = (() => Promise.resolve(null))();
/** /**
* @description * @description

6
packages/http/src/static_request.ts
View File

@ -185,7 +185,7 @@ function urlEncodeParams(params: {[key: string]: any}): URLSearchParams {
const noop = function() {}; const noop = function() {};
const w = typeof window == 'object' ? window : noop; const w = typeof window == 'object' ? window : noop;
const FormData = (w as any /** TODO #9100 */)['FormData'] || noop; const FormData = (() => (w as any /** TODO #9100 */)['FormData'] || noop)();
const Blob = (w as any /** TODO #9100 */)['Blob'] || noop; const Blob = (() => (w as any /** TODO #9100 */)['Blob'] || noop)();
export const ArrayBuffer: ArrayBufferConstructor = export const ArrayBuffer: ArrayBufferConstructor =
(w as any /** TODO #9100 */)['ArrayBuffer'] || noop; (() => (w as any /** TODO #9100 */)['ArrayBuffer'] || noop)();

14
packages/platform-browser/src/browser/browser_adapter.ts
View File

@ -63,13 +63,15 @@ const _chromeNumKeyPadMap = {
'\x90': 'NumLock' '\x90': 'NumLock'
}; };
let nodeContains: (a: any, b: any) => boolean; const nodeContains: (a: any, b: any) => boolean = (() => {
if (global['Node']) {
return global['Node'].prototype.contains || function(node: any) {
return !!(this.compareDocumentPosition(node) & 16);
};
}
if (global['Node']) { return undefined as any;
nodeContains = global['Node'].prototype.contains || function(node) { })();
return !!(this.compareDocumentPosition(node) & 16);
};
}
/** /**
* A `DomAdapter` powered by full browser DOM APIs. * A `DomAdapter` powered by full browser DOM APIs.

25
packages/platform-browser/src/dom/debug/ng_probe.ts
View File

@ -6,13 +6,14 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import * as core from '@angular/core'; import {APP_INITIALIZER, ApplicationRef, DebugNode, NgProbeToken, NgZone, Optional, Provider, getDebugNode} from '@angular/core';
import {exportNgVar} from '../util'; import {exportNgVar} from '../util';
const CORE_TOKENS = { const CORE_TOKENS = (() => ({
'ApplicationRef': core.ApplicationRef, 'ApplicationRef': ApplicationRef,
'NgZone': core.NgZone, 'NgZone': NgZone,
}; }))();
const INSPECT_GLOBAL_NAME = 'probe'; const INSPECT_GLOBAL_NAME = 'probe';
const CORE_TOKENS_GLOBAL_NAME = 'coreTokens'; const CORE_TOKENS_GLOBAL_NAME = 'coreTokens';
@ -22,17 +23,17 @@ const CORE_TOKENS_GLOBAL_NAME = 'coreTokens';
* null if the given native element does not have an Angular view associated * null if the given native element does not have an Angular view associated
* with it. * with it.
*/ */
export function inspectNativeElement(element: any): core.DebugNode|null { export function inspectNativeElement(element: any): DebugNode|null {
return core.getDebugNode(element); return getDebugNode(element);
} }
export function _createNgProbe(coreTokens: core.NgProbeToken[]): any { export function _createNgProbe(coreTokens: NgProbeToken[]): any {
exportNgVar(INSPECT_GLOBAL_NAME, inspectNativeElement); exportNgVar(INSPECT_GLOBAL_NAME, inspectNativeElement);
exportNgVar(CORE_TOKENS_GLOBAL_NAME, {...CORE_TOKENS, ..._ngProbeTokensToMap(coreTokens || [])}); exportNgVar(CORE_TOKENS_GLOBAL_NAME, {...CORE_TOKENS, ..._ngProbeTokensToMap(coreTokens || [])});
return () => inspectNativeElement; return () => inspectNativeElement;
} }
function _ngProbeTokensToMap(tokens: core.NgProbeToken[]): {[name: string]: any} { function _ngProbeTokensToMap(tokens: NgProbeToken[]): {[name: string]: any} {
return tokens.reduce((prev: any, t: any) => (prev[t.name] = t.token, prev), {}); return tokens.reduce((prev: any, t: any) => (prev[t.name] = t.token, prev), {});
} }
@ -48,12 +49,12 @@ export const ELEMENT_PROBE_PROVIDERS__POST_R3__ = [];
/** /**
* Providers which support debugging Angular applications (e.g. via `ng.probe`). * Providers which support debugging Angular applications (e.g. via `ng.probe`).
*/ */
export const ELEMENT_PROBE_PROVIDERS__PRE_R3__: core.Provider[] = [ export const ELEMENT_PROBE_PROVIDERS__PRE_R3__: Provider[] = [
{ {
provide: core.APP_INITIALIZER, provide: APP_INITIALIZER,
useFactory: _createNgProbe, useFactory: _createNgProbe,
deps: [ deps: [
[core.NgProbeToken, new core.Optional()], [NgProbeToken, new Optional()],
], ],
multi: true, multi: true,
}, },

2
packages/platform-browser/src/dom/dom_renderer.ts
View File

@ -231,7 +231,7 @@ class DefaultDomRenderer2 implements Renderer2 {
} }
} }
const AT_CHARCODE = '@'.charCodeAt(0); const AT_CHARCODE = (() => '@'.charCodeAt(0))();
function checkNoSyntheticProp(name: string, nameKind: string) { function checkNoSyntheticProp(name: string, nameKind: string) {
if (name.charCodeAt(0) === AT_CHARCODE) { if (name.charCodeAt(0) === AT_CHARCODE) {
throw new Error( throw new Error(

24
packages/platform-browser/src/dom/events/dom_events.ts
View File

@ -18,9 +18,8 @@ import {EventManagerPlugin} from './event_manager';
* addEventListener by 3x. * addEventListener by 3x.
*/ */
const __symbol__ = const __symbol__ =
(typeof Zone !== 'undefined') && (Zone as any)['__symbol__'] || function(v: string): string { (() => (typeof Zone !== 'undefined') && (Zone as any)['__symbol__'] ||
return '__zone_symbol__' + v; function(v: string): string { return '__zone_symbol__' + v; })();
};
const ADD_EVENT_LISTENER: 'addEventListener' = __symbol__('addEventListener'); const ADD_EVENT_LISTENER: 'addEventListener' = __symbol__('addEventListener');
const REMOVE_EVENT_LISTENER: 'removeEventListener' = __symbol__('removeEventListener'); const REMOVE_EVENT_LISTENER: 'removeEventListener' = __symbol__('removeEventListener');
@ -35,13 +34,18 @@ const NATIVE_REMOVE_LISTENER = 'removeEventListener';
const stopSymbol = '__zone_symbol__propagationStopped'; const stopSymbol = '__zone_symbol__propagationStopped';
const stopMethodSymbol = '__zone_symbol__stopImmediatePropagation'; const stopMethodSymbol = '__zone_symbol__stopImmediatePropagation';
const blackListedEvents: string[] =
(typeof Zone !== 'undefined') && (Zone as any)[__symbol__('BLACK_LISTED_EVENTS')]; const blackListedMap = (() => {
let blackListedMap: {[eventName: string]: string}; const blackListedEvents: string[] =
if (blackListedEvents) { (typeof Zone !== 'undefined') && (Zone as any)[__symbol__('BLACK_LISTED_EVENTS')];
blackListedMap = {}; if (blackListedEvents) {
blackListedEvents.forEach(eventName => { blackListedMap[eventName] = eventName; }); const res: {[eventName: string]: string} = {};
} blackListedEvents.forEach(eventName => { res[eventName] = eventName; });
return res;
}
return undefined;
})();
const isBlackListedEvent = function(eventName: string) { const isBlackListedEvent = function(eventName: string) {
if (!blackListedMap) { if (!blackListedMap) {

17
tslint.json
View File

@ -2,7 +2,8 @@
"rulesDirectory": [ "rulesDirectory": [
"dist/tools/tslint", "dist/tools/tslint",
"node_modules/vrsource-tslint-rules/rules", "node_modules/vrsource-tslint-rules/rules",
"node_modules/tslint-eslint-rules/dist/rules" "node_modules/tslint-eslint-rules/dist/rules",
"node_modules/tslint-no-toplevel-property-access/rules"
], ],
"rules": { "rules": {
"file-header": [ "file-header": [
@ -18,6 +19,18 @@
"no-jasmine-focus": true, "no-jasmine-focus": true,
"no-var-keyword": true, "no-var-keyword": true,
"require-internal-with-underscore": true, "require-internal-with-underscore": true,
"no-toplevel-property-access": [
true,
"packages/animations/src/",
"packages/animations/browser/",
"packages/common/src/",
"packages/core/src/",
"packages/elements/src/",
"packages/forms/src/",
"packages/http/src/",
"packages/platform-browser/src/",
"packages/router/src/"
],
"semicolon": [ "semicolon": [
true true
], ],
@ -56,4 +69,4 @@
"function" "function"
] ]
} }
} }

5
yarn.lock
View File

@ -10977,6 +10977,11 @@ tslint-eslint-rules@4.1.1:
tslib "^1.0.0" tslib "^1.0.0"
tsutils "^1.4.0" tsutils "^1.4.0"
tslint-no-toplevel-property-access@0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/tslint-no-toplevel-property-access/-/tslint-no-toplevel-property-access-0.0.2.tgz#c9b19bbd525ea7b8577e5ada601cc8625b4ed004"
integrity sha512-Oc+UUurlGLBkgeUSGxMoTpRUpaXsjqzQCEAYrYQyuU8330fi5FKlye5n53y87EJ24AlfdoxMPV7DJfFOADapfg==
tslint@5.7.0: tslint@5.7.0:
version "5.7.0" version "5.7.0"
resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.7.0.tgz#c25e0d0c92fa1201c2bc30e844e08e682b4f3552" resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.7.0.tgz#c25e0d0c92fa1201c2bc30e844e08e682b4f3552"