From ad753d3fa7f5d45cc72c9d90b2aeff7eb437f779 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Wed, 2 Oct 2019 12:56:22 +0300 Subject: [PATCH] build(docs-infra): pin terser to 4.3.2 to avoid optimization bug (#32923) This commit pins terser to version 4.3.2 (instead of 4.3.4 which it is currently resolved to) to avoid this bug: terser/terser#470 See https://github.com/angular/angular/pull/32923#issuecomment-537370090 for more details. PR Close #32923 --- aio/package.json | 5 +++++ aio/scripts/_payload-limits.json | 12 ++++++------ aio/yarn.lock | 20 +------------------- 3 files changed, 12 insertions(+), 25 deletions(-) diff --git a/aio/package.json b/aio/package.json index ee83f8fb69..7e0c2b4511 100644 --- a/aio/package.json +++ b/aio/package.json @@ -173,5 +173,10 @@ "watchr": "^3.0.1", "xregexp": "^4.0.0", "yargs": "^7.0.2" + }, + "resolutions": { + "//terser-workaround": "Work-around for https://github.com/terser/terser/issues/470.", + "//terser-workaround": "Remove once terser@4.3.5 is released (with a fix).", + "@angular-devkit/build-angular/**/terser": "4.3.2" } } diff --git a/aio/scripts/_payload-limits.json b/aio/scripts/_payload-limits.json index c4dd7c6c55..b3fd031f01 100755 --- a/aio/scripts/_payload-limits.json +++ b/aio/scripts/_payload-limits.json @@ -4,8 +4,8 @@ "uncompressed": { "runtime-es5": 2990, "runtime-es2015": 2996, - "main-es5": 500653, - "main-es2015": 457297, + "main-es5": 500621, + "main-es2015": 455736, "polyfills-es5": 142383, "polyfills-es2015": 52608 } @@ -16,8 +16,8 @@ "uncompressed": { "runtime-es5": 2990, "runtime-es2015": 2996, - "main-es5": 501393, - "main-es2015": 458422, + "main-es5": 501361, + "main-es2015": 456861, "polyfills-es5": 142383, "polyfills-es2015": 52608 } @@ -28,8 +28,8 @@ "uncompressed": { "runtime-es5": 3100, "runtime-es2015": 3106, - "main-es5": 482744, - "main-es2015": 448708, + "main-es5": 482632, + "main-es2015": 437453, "polyfills-es5": 142383, "polyfills-es2015": 52608 } diff --git a/aio/yarn.lock b/aio/yarn.lock index b620fb9565..9f6e54f67b 100644 --- a/aio/yarn.lock +++ b/aio/yarn.lock @@ -11372,7 +11372,7 @@ terser-webpack-plugin@^1.4.1: webpack-sources "^1.4.0" worker-farm "^1.7.0" -terser@4.3.2: +terser@4.3.2, terser@^4.1.2, terser@^4.3.1: version "4.3.2" resolved "https://registry.yarnpkg.com/terser/-/terser-4.3.2.tgz#ed830de484b0103652799063e605618e80f97f93" integrity sha512-obxk4x19Zlzj9zY4QeXj9iPCb5W8YGn4v3pn4/fHj0Nw8+R7N02Kvwvz9VpOItCZZD8RC+vnYCDL0gP6FAJ7Xg== @@ -11381,24 +11381,6 @@ terser@4.3.2: source-map "~0.6.1" source-map-support "~0.5.12" -terser@^4.1.2: - version "4.3.1" - resolved "https://registry.yarnpkg.com/terser/-/terser-4.3.1.tgz#09820bcb3398299c4b48d9a86aefc65127d0ed65" - integrity sha512-pnzH6dnFEsR2aa2SJaKb1uSCl3QmIsJ8dEkj0Fky+2AwMMcC9doMqLOQIH6wVTEKaVfKVvLSk5qxPBEZT9mywg== - dependencies: - commander "^2.20.0" - source-map "~0.6.1" - source-map-support "~0.5.12" - -terser@^4.3.1: - version "4.3.4" - resolved "https://registry.yarnpkg.com/terser/-/terser-4.3.4.tgz#ad91bade95619e3434685d69efa621a5af5f877d" - integrity sha512-Kcrn3RiW8NtHBP0ssOAzwa2MsIRQ8lJWiBG/K7JgqPlomA3mtb2DEmp4/hrUA+Jujx+WZ02zqd7GYD+QRBB/2Q== - dependencies: - commander "^2.20.0" - source-map "~0.6.1" - source-map-support "~0.5.12" - text-table@~0.2.0: version "0.2.0" resolved "https://registry.yarnpkg.com/text-table/-/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4"