chore(lint): enable requireInternalWithUnderscore tslint check
This commit is contained in:
parent
2019050db2
commit
b5d14c26d2
|
@ -123,6 +123,7 @@ class _AnimationBuilder implements AnimationAstVisitor {
|
||||||
return this._callAnimateMethod(ast, startingStylesExpr, o.literalArr(keyframeExpressions));
|
return this._callAnimateMethod(ast, startingStylesExpr, o.literalArr(keyframeExpressions));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** @internal */
|
||||||
_visitEndStateAnimation(ast: AnimationStepAst,
|
_visitEndStateAnimation(ast: AnimationStepAst,
|
||||||
context: _AnimationBuilderContext): o.Expression {
|
context: _AnimationBuilderContext): o.Expression {
|
||||||
var startingStylesExpr = ast.startingStyles.visit(this, context);
|
var startingStylesExpr = ast.startingStyles.visit(this, context);
|
||||||
|
@ -136,6 +137,7 @@ class _AnimationBuilder implements AnimationAstVisitor {
|
||||||
return this._callAnimateMethod(ast, startingStylesExpr, keyframesExpr);
|
return this._callAnimateMethod(ast, startingStylesExpr, keyframesExpr);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** @internal */
|
||||||
_callAnimateMethod(ast: AnimationStepAst, startingStylesExpr, keyframesExpr) {
|
_callAnimateMethod(ast: AnimationStepAst, startingStylesExpr, keyframesExpr) {
|
||||||
return _ANIMATION_FACTORY_RENDERER_VAR.callMethod('animate', [
|
return _ANIMATION_FACTORY_RENDERER_VAR.callMethod('animate', [
|
||||||
_ANIMATION_FACTORY_ELEMENT_VAR,
|
_ANIMATION_FACTORY_ELEMENT_VAR,
|
||||||
|
|
|
@ -168,6 +168,7 @@ export class TemplateParser {
|
||||||
return new TemplateParseResult(result, errors);
|
return new TemplateParseResult(result, errors);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** @internal */
|
||||||
_assertNoReferenceDuplicationOnTemplate(result:any[], errors:TemplateParseError[]):void {
|
_assertNoReferenceDuplicationOnTemplate(result:any[], errors:TemplateParseError[]):void {
|
||||||
const existingReferences = [];
|
const existingReferences = [];
|
||||||
result
|
result
|
||||||
|
|
|
@ -33,6 +33,8 @@ const PREAMBLE = `/**
|
||||||
* This file is generated by the Angular 2 template compiler.
|
* This file is generated by the Angular 2 template compiler.
|
||||||
* Do not edit.
|
* Do not edit.
|
||||||
*/
|
*/
|
||||||
|
/* tslint:disable */
|
||||||
|
|
||||||
`;
|
`;
|
||||||
|
|
||||||
export class CodeGenerator {
|
export class CodeGenerator {
|
||||||
|
|
|
@ -21,8 +21,8 @@ import * as provider_util from './src/di/provider_util';
|
||||||
import * as console from './src/console';
|
import * as console from './src/console';
|
||||||
import {Provider} from './index';
|
import {Provider} from './index';
|
||||||
import * as reflection from './src/reflection/reflection';
|
import * as reflection from './src/reflection/reflection';
|
||||||
// tslint:disable-next-line
|
// We need to import this name separately from the above wildcard, because this symbol is exposed.
|
||||||
import {Reflector} from './src/reflection/reflection';
|
import {Reflector} from './src/reflection/reflection'; // tslint:disable-line
|
||||||
|
|
||||||
import {
|
import {
|
||||||
NoOpAnimationPlayer as NoOpAnimationPlayer_,
|
NoOpAnimationPlayer as NoOpAnimationPlayer_,
|
||||||
|
|
|
@ -16,11 +16,13 @@ export abstract class AnimationPlayer {
|
||||||
}
|
}
|
||||||
|
|
||||||
export class NoOpAnimationPlayer implements AnimationPlayer {
|
export class NoOpAnimationPlayer implements AnimationPlayer {
|
||||||
|
|
||||||
private _subscriptions = [];
|
private _subscriptions = [];
|
||||||
public parentPlayer: AnimationPlayer = null;
|
public parentPlayer: AnimationPlayer = null;
|
||||||
constructor() {
|
constructor() {
|
||||||
scheduleMicroTask(() => this._onFinish());
|
scheduleMicroTask(() => this._onFinish());
|
||||||
}
|
}
|
||||||
|
/** @internal */
|
||||||
_onFinish() {
|
_onFinish() {
|
||||||
this._subscriptions.forEach(entry => { entry(); });
|
this._subscriptions.forEach(entry => { entry(); });
|
||||||
this._subscriptions = [];
|
this._subscriptions = [];
|
||||||
|
|
|
@ -212,6 +212,7 @@ export class SpyObject {
|
||||||
return object;
|
return object;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** @internal */
|
||||||
_createGuinnessCompatibleSpy(name): GuinessCompatibleSpy {
|
_createGuinnessCompatibleSpy(name): GuinessCompatibleSpy {
|
||||||
var newSpy: GuinessCompatibleSpy = <any>jasmine.createSpy(name);
|
var newSpy: GuinessCompatibleSpy = <any>jasmine.createSpy(name);
|
||||||
newSpy.andCallFake = <any>newSpy.and.callFake;
|
newSpy.andCallFake = <any>newSpy.and.callFake;
|
||||||
|
|
|
@ -109,6 +109,7 @@ export class EventEmitter<T> extends Subject<T> {
|
||||||
// we can't mark it as internal now because EventEmitter exported via @angular/core would not
|
// we can't mark it as internal now because EventEmitter exported via @angular/core would not
|
||||||
// contain this property making it incompatible with all the code that uses EventEmitter via
|
// contain this property making it incompatible with all the code that uses EventEmitter via
|
||||||
// facades, which are local to the code and do not have this property stripped.
|
// facades, which are local to the code and do not have this property stripped.
|
||||||
|
// tslint:disable-next-line
|
||||||
__isAsync: boolean;
|
__isAsync: boolean;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
@ -1,5 +1,6 @@
|
||||||
{
|
{
|
||||||
"rules": {
|
"rules": {
|
||||||
|
"requireInternalWithUnderscore": true,
|
||||||
"duplicateModuleImport": true,
|
"duplicateModuleImport": true,
|
||||||
"semicolon": true,
|
"semicolon": true,
|
||||||
"variable-name": false
|
"variable-name": false
|
||||||
|
|
Loading…
Reference in New Issue