From b800a0c824f83f4faf12bfe7fc34cc12982af6f7 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Thu, 23 Mar 2017 14:54:19 -0700 Subject: [PATCH] fix: prevent strictNullChecks support until #15432 is fixed (#15434) --- integration/hello_world__closure/tsconfig.json | 3 ++- integration/typings_test_ts21/tsconfig.json | 3 ++- integration/typings_test_ts22/tsconfig.json | 3 ++- packages/core/public_api.ts | 6 ++++++ packages/platform-server/integrationtest/tsconfig.json | 3 ++- 5 files changed, 14 insertions(+), 4 deletions(-) diff --git a/integration/hello_world__closure/tsconfig.json b/integration/hello_world__closure/tsconfig.json index 25ba5a8fc7..0703f4d82a 100644 --- a/integration/hello_world__closure/tsconfig.json +++ b/integration/hello_world__closure/tsconfig.json @@ -7,7 +7,8 @@ "compilerOptions": { "module": "es2015", "moduleResolution": "node", - "strictNullChecks": true, + // TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432 + "strictNullChecks": false, "target": "es6", "noImplicitAny": false, "sourceMap": false, diff --git a/integration/typings_test_ts21/tsconfig.json b/integration/typings_test_ts21/tsconfig.json index 468b20cdac..7c9539fff6 100644 --- a/integration/typings_test_ts21/tsconfig.json +++ b/integration/typings_test_ts21/tsconfig.json @@ -9,7 +9,8 @@ "target": "es5", "lib": ["es5", "dom", "es2015.collection", "es2015.iterable", "es2015.promise"], "types": [], - "strictNullChecks": true + // TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432 + "strictNullChecks": false }, "files": [ "include-all.ts", diff --git a/integration/typings_test_ts22/tsconfig.json b/integration/typings_test_ts22/tsconfig.json index 1b19900654..02f12fe4b7 100644 --- a/integration/typings_test_ts22/tsconfig.json +++ b/integration/typings_test_ts22/tsconfig.json @@ -15,7 +15,8 @@ "es2015.promise" ], "types": [], - "strictNullChecks": true + // TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432 + "strictNullChecks": false }, "files": [ "include-all.ts", diff --git a/packages/core/public_api.ts b/packages/core/public_api.ts index ede0762054..d0b16c5459 100644 --- a/packages/core/public_api.ts +++ b/packages/core/public_api.ts @@ -14,3 +14,9 @@ export * from './src/core'; // This file only reexports content of the `src` folder. Keep it that way. + +// This is a hack to prevent people from turning on strictNullChecks. See #15432 +export declare interface ɵStrictNullChecksNotSupported { + dontUseStrictNullChecksWithAngularYetSeeIssue15432: string|null; + [key: string]: string; +} diff --git a/packages/platform-server/integrationtest/tsconfig.json b/packages/platform-server/integrationtest/tsconfig.json index e728bdcd6e..8273ac4dac 100644 --- a/packages/platform-server/integrationtest/tsconfig.json +++ b/packages/platform-server/integrationtest/tsconfig.json @@ -7,7 +7,8 @@ "compilerOptions": { "module": "es2015", "moduleResolution": "node", - "strictNullChecks": true, + // TODO(i): strictNullChecks should turned on but are temporarily disabled due to #15432 + "strictNullChecks": false, "target": "es6", "noImplicitAny": false, "sourceMap": false,