honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf(ivy): stricter null checks in setInputsFromAttrs (#33102) 

PR Close #33102
This commit is contained in:
Pawel Kozlowski 2019-10-11 11:32:48 +02:00 committed by Miško Hevery
parent 0b1daa9ebd
commit b800b88224
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/render3/instructions/shared.ts
View File

@ -1091,7 +1091,7 @@ export function resolveDirectives(
function instantiateAllDirectives(tView: TView, lView: LView, tNode: TNode) { function instantiateAllDirectives(tView: TView, lView: LView, tNode: TNode) {
const start = tNode.directiveStart; const start = tNode.directiveStart;
const end = tNode.directiveEnd; const end = tNode.directiveEnd;
if (!tView.firstTemplatePass && start < end) { if (!tView.firstTemplatePass) {
getOrCreateNodeInjectorForNode( getOrCreateNodeInjectorForNode(
tNode as TElementNode | TContainerNode | TElementContainerNode, lView); tNode as TElementNode | TContainerNode | TElementContainerNode, lView);
} }
@ -1367,13 +1367,13 @@ function setInputsFromAttrs<T>(
} }
const initialInputs: InitialInputs|null = initialInputData[directiveIndex]; const initialInputs: InitialInputs|null = initialInputData[directiveIndex];
if (initialInputs) { if (initialInputs !== null) {
const setInput = def.setInput; const setInput = def.setInput;
for (let i = 0; i < initialInputs.length;) { for (let i = 0; i < initialInputs.length;) {
const publicName = initialInputs[i++]; const publicName = initialInputs[i++];
const privateName = initialInputs[i++]; const privateName = initialInputs[i++];
const value = initialInputs[i++]; const value = initialInputs[i++];
if (setInput) { if (setInput !== null) {
def.setInput !(instance, value, publicName, privateName); def.setInput !(instance, value, publicName, privateName);
} else { } else {
(instance as any)[privateName] = value; (instance as any)[privateName] = value;