honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(compiler): don’t workaround a fixed tsickle bug (#19301) 

PR Close #19301
This commit is contained in:
Tobias Bosch 2017-09-20 10:00:01 -07:00 committed by Igor Minar
parent 4586fccae4
commit b826e0c636
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/bazel/src/ngc-wrapped/index.ts
View File

@ -103,7 +103,7 @@ export function compile(
} }
}; };
// Patch fileExists when resolving modules, so that ngc can ask TypeScript to // Patch fileExists when resolving modules, so that CompilerHost can ask TypeScript to
// resolve non-existing generated files that don't exist on disk, but are // resolve non-existing generated files that don't exist on disk, but are
// synthetic and added to the `programWithStubs` based on real inputs. // synthetic and added to the `programWithStubs` based on real inputs.
const generatedFileModuleResolverHost = Object.create(tsHost); const generatedFileModuleResolverHost = Object.create(tsHost);
@ -143,12 +143,6 @@ export function compile(
} }
return origBazelHostFileExist.call(bazelHost, fileName); return origBazelHostFileExist.call(bazelHost, fileName);
}; };
// TODO(tbosch): fix tsickle to still run regular transformers even
// if tsickle is not processing a file, and then remove this override,
// as this is only required to keep the ng transformer running,
// but produces e.g. too many externs.
bazelHost.shouldSkipTsickleProcessing = (fileName: string): boolean =>
bazelOpts.compilationTargetSrc.indexOf(fileName) === -1 && !NGC_GEN_FILES.test(fileName);
const ngHost = ng.createCompilerHost({options: compilerOpts, tsHost: bazelHost}); const ngHost = ng.createCompilerHost({options: compilerOpts, tsHost: bazelHost});