From b84855f394186f9b7acf6c78ef781a39b3d75461 Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Tue, 27 Oct 2015 18:38:47 -0700 Subject: [PATCH] refactor: private methods should not be decorated with internal Closes #5146 --- .../change_detection/dynamic_change_detector.ts | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/modules/angular2/src/core/change_detection/dynamic_change_detector.ts b/modules/angular2/src/core/change_detection/dynamic_change_detector.ts index 7842da7935..41ee49e149 100644 --- a/modules/angular2/src/core/change_detection/dynamic_change_detector.ts +++ b/modules/angular2/src/core/change_detection/dynamic_change_detector.ts @@ -299,7 +299,6 @@ export class DynamicChangeDetector extends AbstractChangeDetector { } } - /** @internal */ private _calculateCurrValue(proto: ProtoRecord, values: any[], locals: Locals) { switch (proto.mode) { case RecordType.Self: @@ -367,7 +366,6 @@ export class DynamicChangeDetector extends AbstractChangeDetector { } } - /** @internal */ private _pipeCheck(proto: ProtoRecord, throwOnChange: boolean, values: any[]) { var context = this._readContext(proto, values); var selectedPipe = this._pipeFor(proto, context); @@ -406,7 +404,6 @@ export class DynamicChangeDetector extends AbstractChangeDetector { } } - /** @internal */ private _pipeFor(proto: ProtoRecord, context) { var storedPipe = this._readPipe(proto); if (isPresent(storedPipe)) return storedPipe; @@ -416,7 +413,6 @@ export class DynamicChangeDetector extends AbstractChangeDetector { return pipe; } - /** @internal */ private _readContext(proto: ProtoRecord, values: any[]) { if (proto.contextIndex == -1) { return this._getDirectiveFor(proto.directiveIndex); @@ -424,29 +420,22 @@ export class DynamicChangeDetector extends AbstractChangeDetector { return values[proto.contextIndex]; } - /** @internal */ private _readSelf(proto: ProtoRecord, values: any[]) { return values[proto.selfIndex]; } - /** @internal */ private _writeSelf(proto: ProtoRecord, value, values: any[]) { values[proto.selfIndex] = value; } - /** @internal */ private _readPipe(proto: ProtoRecord) { return this.localPipes[proto.selfIndex]; } - /** @internal */ private _writePipe(proto: ProtoRecord, value) { this.localPipes[proto.selfIndex] = value; } - /** @internal */ private _setChanged(proto: ProtoRecord, value: boolean) { if (proto.argumentToPureFunction) this.changes[proto.selfIndex] = value; } - /** @internal */ private _pureFuncAndArgsDidNotChange(proto: ProtoRecord): boolean { return proto.isPureFunction() && !this._argsChanged(proto); } - /** @internal */ private _argsChanged(proto: ProtoRecord): boolean { var args = proto.args; for (var i = 0; i < args.length; ++i) { @@ -457,12 +446,10 @@ export class DynamicChangeDetector extends AbstractChangeDetector { return false; } - /** @internal */ private _argsOrContextChanged(proto: ProtoRecord): boolean { return this._argsChanged(proto) || this.changes[proto.contextIndex]; } - /** @internal */ private _readArgs(proto: ProtoRecord, values: any[]) { var res = ListWrapper.createFixedSize(proto.args.length); var args = proto.args;