honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ListWrapper): make list slice in dart return empty list if start and end are inverted like JS

Browse Source
This commit is contained in:
Lenny 2015-08-30 17:03:37 -07:00 committed by vsavkin
parent 105db02e07
commit bced3aaa17
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/angular2/src/core/facade/collection.dart
View File

@ -182,6 +182,10 @@ class ListWrapper {
} }
static List slice(List l, [int from = 0, int to]) { static List slice(List l, [int from = 0, int to]) {
//in JS if from > to an empty array is returned
if(to != null && from > to) {
return [];
}
return l.sublist(_startOffset(l, from), _endOffset(l, to)); return l.sublist(_startOffset(l, from), _endOffset(l, to));
} }

3
modules/angular2/test/core/facade/collection_spec.ts
View File

@ -62,6 +62,9 @@ export function main() {
it('should support negative end', it('should support negative end',
() => { expect(ListWrapper.slice(l, -3, -1)).toEqual([2, 3]); }); () => { expect(ListWrapper.slice(l, -3, -1)).toEqual([2, 3]); });
it('should return empty list if start is greater than end',
() => { expect(ListWrapper.slice(l, 4, 2)).toEqual([]); });
}); });
describe('indexOf', () => { describe('indexOf', () => {