honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: roll back phased review conditions (#38257) 

It was determined that the list of 'pending' groups also included inactive groups.
That means that the 'no-groups-above-this-pending' would generally fail because
there's almost always some inactive group above it.

This commit removes the conditions for phased review while we
investigate if the inactive groups can be excluded.

PR Close #38257
This commit is contained in:
Andrew Scott 2020-07-27 16:26:31 -07:00 committed by Misko Hevery
parent cf98db28d5
commit be3e7050d5
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.pullapprove.yml
View File

@ -1160,8 +1160,6 @@ groups:
public-api: public-api:
<<: *defaults <<: *defaults
conditions: conditions:
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
- *can-be-global-approved - *can-be-global-approved
- > - >
contains_any_globs(files, [ contains_any_globs(files, [
@ -1194,8 +1192,6 @@ groups:
size-tracking: size-tracking:
<<: *defaults <<: *defaults
conditions: conditions:
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
- *can-be-global-approved - *can-be-global-approved
- > - >
contains_any_globs(files, [ contains_any_globs(files, [
@ -1222,8 +1218,6 @@ groups:
circular-dependencies: circular-dependencies:
<<: *defaults <<: *defaults
conditions: conditions:
- *no-groups-above-this-pending
- *no-groups-above-this-rejected
- *can-be-global-approved - *can-be-global-approved
- > - >
contains_any_globs(files, [ contains_any_globs(files, [