honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: remove 'PR target: review' label (#29227) 

We have switched to using Github's `Review` feature to request and track if a PR needs review. Therefore this label can be removed.

PR Close #29227
This commit is contained in:
Jason Aden 2019-03-11 09:52:50 -07:00 committed by Matias Niemelä
parent 1fb670e06c
commit bf0704d685
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/TRIAGE_AND_LABELS.md
View File

@ -122,7 +122,6 @@ PRs also have additional label categories that should be used to signal their st
Every triaged PR must have a `pr_action` label assigned to it: Every triaged PR must have a `pr_action` label assigned to it:
* `PR action: review` - work is complete and comment is needed from the reviewers.
* `PR action: cleanup` - more work is needed from the author. * `PR action: cleanup` - more work is needed from the author.
* `PR action: discuss` - discussion is needed, to be led by the author. * `PR action: discuss` - discussion is needed, to be led by the author.
* `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready". * `PR action: merge` - the PR author is ready for the changes to be merged by the caretaker as soon as the PR is green (or merge-assistance label is applied and caretaker has deemed it acceptable manually). In other words, this label indicates to "auto submit when ready".
@ -133,6 +132,8 @@ In addition, PRs can have the following states:
* `PR state: WIP` - PR is experimental or rapidly changing. Not ready for review or triage. * `PR state: WIP` - PR is experimental or rapidly changing. Not ready for review or triage.
* `PR state: blocked` - PR is blocked on an issue or other PR. Not ready for review or triage or merge. * `PR state: blocked` - PR is blocked on an issue or other PR. Not ready for review or triage or merge.
When a PR is ready for review, a review should be requested using the Reviewers interface in Github.
## PR Target ## PR Target