From bf57df3e04e63d9c01ad55519ddab963f0250c1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Mon, 30 Oct 2017 15:05:35 -0700 Subject: [PATCH] build: temporarily increase the commit msg limit to 120 Right now HEAD and 5.0.x have a branch deviation and therefore all the commits between both branches are being compared. There exists a problematic commit which has a commit message that is longer than 100 commits. This patch will temporarily increase the limit to 120 so that CI passes. Once master is resumed to being the primary development branch (once 5.0.0 is out) then the the msg limit will be set back to 100. --- tools/validate-commit-message/commit-message.json | 2 +- tools/validate-commit-message/validate-commit-message.spec.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/validate-commit-message/commit-message.json b/tools/validate-commit-message/commit-message.json index 6e0b33b623..1d5c98053f 100644 --- a/tools/validate-commit-message/commit-message.json +++ b/tools/validate-commit-message/commit-message.json @@ -1,5 +1,5 @@ { - "maxLength": 100, + "maxLength": 120, "types": [ "build", "ci", diff --git a/tools/validate-commit-message/validate-commit-message.spec.js b/tools/validate-commit-message/validate-commit-message.spec.js index ee948e48c9..468865efb5 100644 --- a/tools/validate-commit-message/validate-commit-message.spec.js +++ b/tools/validate-commit-message/validate-commit-message.spec.js @@ -70,11 +70,11 @@ describe('validate-commit-message.js', function() { it('should validate 100 characters length', function() { var msg = - 'fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer... '; + 'fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer and longer and longer and longer... '; expect(validateMessage(msg)).toBe(INVALID); expect(errors).toEqual([ - 'INVALID COMMIT MSG: "fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer... "\n => ERROR: The commit message is longer than 100 characters' + 'INVALID COMMIT MSG: "fix(compiler): something super mega extra giga tera long, maybe even longer and longer and longer and longer and longer and longer... "\n => ERROR: The commit message is longer than 120 characters' ]); });