honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(compiler-cli): fix documentation and JSON schema references in compliance tests (#39707) 

The JSON schema reference was off-by-one, preventing IDEs from finding
the file and offering suggestions and documentation. Additionally the
name of the golden file was slightly off.

PR Close #39707
This commit is contained in:
JoostK 2020-11-16 12:57:18 +01:00 committed by Andrew Kushnir
parent 266959e745
commit bfa20e11a6
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/compiler-cli/test/compliance/README.md
View File

@ -122,8 +122,8 @@ test-cases, which each contain multiple input files, there will only be one gold
The golden file is generated by the tooling and should not be modified manually. The golden file is generated by the tooling and should not be modified manually.
When you first create a test-case, with an empty `PARTIAL_GOLDEN.js` file, or a change is made to When you first create a test-case, with an empty `GOLDEN_PARTIAL.js` file, or a change is made to
the generated partial output, we must update the `PARTIAL_GOLDEN.js` file. the generated partial output, we must update the `GOLDEN_PARTIAL.js` file.
This is done by running a specific bazel rule of the form: This is done by running a specific bazel rule of the form:
@ -132,7 +132,7 @@ bazel run //packages/compiler-cli/test/compliance/test_cases:<path/to/test_case>
``` ```
where to replace `<path/to/test_case>` with the path (relative to `test_cases`) of the directory where to replace `<path/to/test_case>` with the path (relative to `test_cases`) of the directory
that contains the `PARTIAL_GOLDEN.js` to update. that contains the `GOLDEN_PARTIAL.js` to update.
## Debugging test-cases ## Debugging test-cases

2
packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/elements/TEST_CASES.json
View File

@ -1,5 +1,5 @@
{ {
"$schema": "../test_case_schema.json", "$schema": "../../test_case_schema.json",
"cases": [ "cases": [
{ {
"description": "should handle SVG", "description": "should handle SVG",

2
packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/interpolations/TEST_CASES.json
View File

@ -1,5 +1,5 @@
{ {
"$schema": "../test_case_schema.json", "$schema": "../../test_case_schema.json",
"cases": [ "cases": [
{ {
"description": "should generate a correct call to `ɵɵtextInterpolateV()` with more than 8 interpolations", "description": "should generate a correct call to `ɵɵtextInterpolateV()` with more than 8 interpolations",

2
packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_directives/directives/matching/TEST_CASES.json
View File

@ -1,5 +1,5 @@
{ {
"$schema": "../../test_case_schema.json", "$schema": "../../../test_case_schema.json",
"cases": [ "cases": [
{ {
"description": "should not match directives on i18n attribute", "description": "should not match directives on i18n attribute",