honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ivy): run template type-checking for all components (#31952) 

PR Close #31952
This commit is contained in:
Alex Rickabaugh 2019-08-15 13:10:18 -07:00 committed by Andrew Kushnir
parent daac386f4d
commit bfc26bcd8c
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/compiler-cli/src/ngtsc/annotations/src/component.ts
View File

@ -353,15 +353,16 @@ export class ComponentDecoratorHandler implements
if (!ts.isClassDeclaration(node)) { if (!ts.isClassDeclaration(node)) {
return; return;
} }
const scope = this.scopeReader.getScopeForComponent(node);
const pipes = new Map<string, Reference<ClassDeclaration<ts.ClassDeclaration>>>();
const matcher = new SelectorMatcher<DirectiveMeta>(); const matcher = new SelectorMatcher<DirectiveMeta>();
const scope = this.scopeReader.getScopeForComponent(node);
if (scope !== null) { if (scope !== null) {
for (const meta of scope.compilation.directives) { for (const meta of scope.compilation.directives) {
const extMeta = flattenInheritedDirectiveMetadata(this.metaReader, meta.ref); const extMeta = flattenInheritedDirectiveMetadata(this.metaReader, meta.ref);
matcher.addSelectables(CssSelector.parse(meta.selector), extMeta); matcher.addSelectables(CssSelector.parse(meta.selector), extMeta);
} }
const bound = new R3TargetBinder(matcher).bind({template: meta.parsedTemplate.nodes});
const pipes = new Map<string, Reference<ClassDeclaration<ts.ClassDeclaration>>>();
for (const {name, ref} of scope.compilation.pipes) { for (const {name, ref} of scope.compilation.pipes) {
if (!ts.isClassDeclaration(ref.node)) { if (!ts.isClassDeclaration(ref.node)) {
throw new Error( throw new Error(
@ -369,8 +370,10 @@ export class ComponentDecoratorHandler implements
} }
pipes.set(name, ref as Reference<ClassDeclaration<ts.ClassDeclaration>>); pipes.set(name, ref as Reference<ClassDeclaration<ts.ClassDeclaration>>);
} }
ctx.addTemplate(new Reference(node), bound, pipes, meta.parsedTemplate.file);
} }
const bound = new R3TargetBinder(matcher).bind({template: meta.parsedTemplate.nodes});
ctx.addTemplate(new Reference(node), bound, pipes, meta.parsedTemplate.file);
} }
resolve(node: ClassDeclaration, analysis: ComponentHandlerData): ResolveResult { resolve(node: ClassDeclaration, analysis: ComponentHandlerData): ResolveResult {