honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(elements): ensure compatibility with noImplicitOverride (#42512) 

Adds the `override` keyword to the `elements` sources to ensure
compatibility with `noImplicitOverride`.

PR Close #42512
This commit is contained in:
Paul Gschwendtner 2021-06-07 21:04:39 +02:00 committed by Andrew Kushnir
parent 22290af178
commit c13ccc37cf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/elements/test/create-custom-element_spec.ts
View File

@ -125,9 +125,9 @@ if (browserDetection.supportsCustomElements) {
it('should not break if `NgElementStrategy#events` is not available before calling `NgElementStrategy#connect()`', it('should not break if `NgElementStrategy#events` is not available before calling `NgElementStrategy#connect()`',
() => { () => {
class TestStrategyWithLateEvents extends TestStrategy { class TestStrategyWithLateEvents extends TestStrategy {
events: Subject<NgElementStrategyEvent> = undefined!; override events: Subject<NgElementStrategyEvent> = undefined!;
connect(element: HTMLElement): void { override connect(element: HTMLElement): void {
this.connectedElement = element; this.connectedElement = element;
this.events = new Subject<NgElementStrategyEvent>(); this.events = new Subject<NgElementStrategyEvent>();
this.events.next({name: 'strategy-event', value: 'connect'}); this.events.next({name: 'strategy-event', value: 'connect'});