ci: fix and re-enable payload size checks for integration tests (#26869)

See #22810, #23376 and #23515 for more context.

Fixes #23376
Closes #23515

PR Close #26869

integration/_payload-limits.json

@@ -3,8 +3,8 @@
     "master": {
       "uncompressed": {
         "runtime": 1110,
-        "main": 151765,
-        "polyfills": 59462
+        "main": 160134,
+        "polyfills": 59620
       }
     }
   },
@@ -12,9 +12,8 @@
     "master": {
       "uncompressed": {
         "bundle": "TODO(i): temporarily increase the payload size limit from 105779 - this is due to a closure issue related to ESM reexports that still needs to be investigated",
-        "bundle": 178101
+        "bundle": 177585
       }
     }
   }
 }
-

integration/run_tests.sh

@@ -15,7 +15,7 @@ if $CI; then
   # We don't install this by default because it contains some broken Bazel setup
   # and also it's a very big dependency that we never use except when publishing
   # payload sizes on CI.
-  yarn add --silent -D firebase-tools@3.12.0
+  yarn add --silent -D firebase-tools@5.1.1
   source ${basedir}/scripts/ci/payload-size.sh
 
   # NB: we don't run build-packages-dist.sh because we expect that it was done
@@ -47,20 +47,21 @@ for testDir in $(ls | grep -v node_modules) ; do
 
     yarn install --cache-folder ../$cache
     yarn test || exit 1
+
     # Track payload size for cli-hello-world and hello_world__closure and the render3 tests
-    if [[ $testDir == cli-hello-world ]] || [[ $testDir == hello_world__closure ]]; then
+    if $CI && ([[ $testDir == cli-hello-world ]] || [[ $testDir == hello_world__closure ]]); then
       if [[ $testDir == cli-hello-world ]]; then
         yarn build
       fi
-      #if $CI; then
-      #  trackPayloadSize "$testDir" "dist/*.js" true false "${basedir}/integration/_payload-limits.json"
-      #fi
+
+      trackPayloadSize "$testDir" "dist/*.js" true false "${basedir}/integration/_payload-limits.json"
     fi
+
     # remove the temporary node modules directory to keep the source folder clean.
     rm -rf node_modules
   )
 done
 
-#if $CI; then
-#  trackPayloadSize "umd" "../dist/packages-dist/*/bundles/*.umd.min.js" false false
-#fi
+if $CI; then
+  trackPayloadSize "umd" "../dist/packages-dist/*/bundles/*.umd.min.js" false false
+fi