honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: re-enable saucelabs non-verbose logging (#27657) 

Previously the logging to TravisCI has been disabled because the `print-logs.sh` file printed the Sauce-Connect logfile output that is `verbose` by default. See [for example](https://travis-ci.org/angular/angular/jobs/250578973).

Since the default stdout/stderr of sauce-connect is pretty much concise and can alert us if we run into any issues (e.g. rate limit, outdated tunnel version), we should stop piping these to `/dev/null`.

PR Close #27657
This commit is contained in:
Paul Gschwendtner 2018-12-13 20:13:24 +01:00 committed by Miško Hevery
parent 31006f734e
commit c6ae72987b
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
scripts/sauce/sauce_connect_setup.sh
View File

@ -22,14 +22,13 @@ CONNECT_URL="https://saucelabs.com/downloads/sc-${SAUCE_CONNECT_VERSION}-linux.t
CONNECT_DIR="/tmp/sauce-connect-$RANDOM" CONNECT_DIR="/tmp/sauce-connect-$RANDOM"
CONNECT_DOWNLOAD="sc-latest-linux.tar.gz" CONNECT_DOWNLOAD="sc-latest-linux.tar.gz"
# logging disabled because it seems to be overwhelming travis and causing flakes # We don't want to create a log file because sauceconnect always logs in verbose mode. This seems
# when we are cat-ing the log in print-logs.sh # to be overwhelming Travis and causing flakes when we are cat-ing the log in "print-logs.sh"
# CONNECT_LOG="$LOGS_DIR/sauce-connect"
# CONNECT_STDOUT="$LOGS_DIR/sauce-connect.stdout"
# CONNECT_STDERR="$LOGS_DIR/sauce-connect.stderr"
CONNECT_LOG="/dev/null" CONNECT_LOG="/dev/null"
# Even though the stdout of sauceconnect is not very verbose, we don't want to log this to
# Travis because it will show up in between different travis log-output groups
CONNECT_STDOUT="/dev/null" CONNECT_STDOUT="/dev/null"
CONNECT_STDERR="/dev/null"
# Get Connect and start it # Get Connect and start it
mkdir -p $CONNECT_DIR mkdir -p $CONNECT_DIR
@ -52,10 +51,7 @@ if [ ! -z "$BROWSER_PROVIDER_READY_FILE" ]; then
fi fi
set -v set -v
echo "Starting Sauce Connect in the background, logging into:" echo "Starting Sauce Connect in the background."
echo " $CONNECT_LOG" sauce-connect/bin/sc -u $SAUCE_USERNAME -k $SAUCE_ACCESS_KEY $ARGS --logfile $CONNECT_LOG \
echo " $CONNECT_STDOUT" > $CONNECT_STDOUT &
echo " $CONNECT_STDERR"
sauce-connect/bin/sc -u $SAUCE_USERNAME -k $SAUCE_ACCESS_KEY $ARGS \
--logfile $CONNECT_LOG 2> $CONNECT_STDERR 1> $CONNECT_STDOUT &
set +v set +v