From c6d9a193d6460f71a4085bef7c4c787e36dba2f9 Mon Sep 17 00:00:00 2001 From: Adem Simsek Date: Tue, 30 Mar 2021 11:48:06 +0200 Subject: [PATCH] fix(dev-infra): Correctly place comments in dockerfile (#41374) The doc in https://docs.docker.com/engine/reference/builder/#format says that "Docker treats lines that begin with # as a comment, unless the line is a valid parser directive. A # marker anywhere else in a line is treated as an argument." Fixes #41361 PR Close #41374 --- .devcontainer/recommended-Dockerfile | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.devcontainer/recommended-Dockerfile b/.devcontainer/recommended-Dockerfile index 251fc54224..87379c1e06 100644 --- a/.devcontainer/recommended-Dockerfile +++ b/.devcontainer/recommended-Dockerfile @@ -1,6 +1,8 @@ # Image metadata and config. -FROM circleci/node:10-browsers # Ideally, the image version should be what we use on CI. - # See `executors > browsers-executor` in `.circleci/config.yml`. +# Ideally, the image version should be what we use on CI. +# See `executors > browsers-executor` in `.circleci/config.yml`. +FROM circleci/node:10-browsers + LABEL name="Angular dev environment" \ description="This image can be used to create a dev environment for building Angular." \ @@ -16,8 +18,10 @@ USER root # Configure `Node.js`/`npm` and install utilities. RUN npm config --global set user root -RUN npm install --global yarn@latest # Ideally, the version should be what we use on CI. - # See `commands > overwrite_yarn` in `.circleci/config.yml`. + +# Ideally, the version should be what we use on CI. +# See `commands > overwrite_yarn` in `.circleci/config.yml`. +RUN npm install --global yarn@latest # Go! (And keep going.)