build: enable noImplicitOverride in project (#42512)

Enables the `noImplicitOverride` option to improve
overall codehealth in the repository.

PR Close #42512

.circleci/config.yml

@@ -678,7 +678,7 @@ jobs:
           background: true
       # add module umd tsc compile option so the test can work
       # properly in the legacy browsers
-      - run: yarn tsc -p packages --module UMD
+      - run: yarn tsc -p packages/tsconfig-legacy-saucelabs.json --module UMD
       - run: yarn tsc -p modules --module UMD
       - run: yarn bazel build //packages/zone.js:npm_package
       # Build test fixtures for a test that rely on Bazel-generated fixtures. Note that disabling

dev-infra/tsconfig.json

@@ -1,6 +1,8 @@
 {
   "compilerOptions": {
     "strict": true,
-    "downlevelIteration": true
+    "downlevelIteration": true,
+    "noImplicitAny": true,
+    "noImplicitOverride": true
   }
 }

packages/core/schematics/tsconfig.json

@@ -1,6 +1,7 @@
 {
   "compilerOptions": {
     "noImplicitReturns": true,
+    "noImplicitOverride": true,
     "noFallthroughCasesInSwitch": true,
     "strict": true,
     "moduleResolution": "node",

packages/service-worker/cli/tsconfig.json

@@ -9,6 +9,7 @@
     "strictPropertyInitialization": true,
     "outDir": "../../../dist/all/@angular/service-worker/cli-custom",
     "noImplicitAny": true,
+    "noImplicitOverride": true,
     "noFallthroughCasesInSwitch": true,
     "rootDir": ".",
     "paths": {

packages/tsconfig-build.json

@@ -8,6 +8,7 @@
     "declaration": true,
     "stripInternal": true,
     "noImplicitAny": true,
+    "noImplicitOverride": true,
     "strictNullChecks": true,
     "strict": true,
     "strictPropertyInitialization": true,

packages/tsconfig-legacy-saucelabs.json

@@ -0,0 +1,11 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    // The project uses Bazel for TypeScript compilation. Unlike with Bazel, we build all
+    // sources as part of a single TypeScript compilation. This results in `@internal`
+    // declarations not being omitted between the logical as defined per the Bazel targets.
+    // This can cause issues where the `override` keyword is needed for the legacy TS
+    // compilation, but not within Bazel where the overridden member has `@internal`.
+    "noImplicitOverride": false,
+  }
+}

packages/tsconfig.json

@@ -14,6 +14,7 @@
     "strictPropertyInitialization": true,
     "outDir": "../dist/all/@angular",
     "noImplicitAny": true,
+    "noImplicitOverride": true,
     "noFallthroughCasesInSwitch": true,
     "paths": {
       "selenium-webdriver": ["./node_modules/@types/selenium-webdriver/index.d.ts"],

packages/zone.js/tsconfig.json

@@ -9,6 +9,7 @@
     "noEmitOnError": false,
     "stripInternal": false,
     "strict": true,
+    "noImplicitOverride": true,
     "lib": [
       "es5",
       "dom",