honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: exclude `service-worker/` sub-directories from `fw-testing` PullApprove group (#42631) 

The `fw-testing` PullApprove group, which by default owns all `testing/`
sub-directories, is supposed to own resources related to testing Angular
applications (from an end-user's perspective). The `service-worker`
package source code includes some `testing/` sub-directories which are
intended for internal use only (i.e. to test the `service-worker`
package itself) and are not distributed to end-users of the package.

Previously, changes in these `testing/` sub-directories would
incorrectly require approval from the `fw-testing` group.

This commit fixes this by excluding the `service-worker` package
sub-directories from the files owned by the `fw-testing` group.

PR Close #42631
This commit is contained in:
George Kalpakas 2021-06-24 20:56:41 +03:00 committed by Jessica Janiuk
parent 4e46aef17b
commit c88e18a051
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pullapprove.yml
View File

@ -665,7 +665,7 @@ groups:
- *can-be-global-approved - *can-be-global-approved
- *can-be-global-docs-approved - *can-be-global-docs-approved
- > - >
contains_any_globs(files.exclude('packages/compiler-cli/**').exclude('packages/language-service/**'), [ contains_any_globs(files.exclude('packages/compiler-cli/**').exclude('packages/language-service/**').exclude('packages/service-worker/**'), [
'packages/**/testing/**', 'packages/**/testing/**',
'aio/content/guide/testing.md', 'aio/content/guide/testing.md',
'aio/content/guide/test-debugging.md', 'aio/content/guide/test-debugging.md',