honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(ivy): avoid type coercion in `saveNameToExportMap` function (#34335) 

TypeScript 3.7 flags `if` conditions that implicitly coerce a function/method definition. While checking for the `template` presence on a def (actually checking whether we work with Component) in `saveNameToExportMap`, the `if` condition had implicit type coercion. This commit updates the condition to use the `isComponentDef` function (that checks `def.template` against `null` internally) to avoid compilation errors with TypeScript 3.7.

PR Close #34335
This commit is contained in:
Andrew Kushnir 2019-12-10 11:48:30 -08:00
parent c8447d21bd
commit c8b5b81516
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/render3/instructions/shared.ts
View File

@ -1304,7 +1304,7 @@ function saveNameToExportMap(
exportsMap[def.exportAs[i]] = index; exportsMap[def.exportAs[i]] = index;
} }
} }
if ((def as ComponentDef<any>).template) exportsMap[''] = index; if (isComponentDef(def)) exportsMap[''] = index;
} }
} }