honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dev-infra): missing pkg_npm substitution for top-level targets being accessed (#42754)

Browse Source 
Currently if a top-level target or file within `//dev-infra` is
being referenced. like `//dev-infra:tsconfig`, then the label
is not subsituted properly and breaks consumption of the built
NPM package.

PR Close #42754
This commit is contained in:
Paul Gschwendtner 2021-07-03 00:27:01 +02:00 committed by atscott
parent 4c78984ad2
commit c9b47f2182
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev-infra/BUILD.bazel
View File

@ -1,9 +1,12 @@
# BEGIN-INTERNAL
load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm") load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
load("@npm//@bazel/typescript:index.bzl", "ts_library") load("@npm//@bazel/typescript:index.bzl", "ts_library")
load("//dev-infra:index.bzl", "ng_dev_rolled_up_generated_file") load("//dev-infra:index.bzl", "ng_dev_rolled_up_generated_file")
# END-INTERNAL
exports_files(["tsconfig.json"]) exports_files(["tsconfig.json"])
# BEGIN-INTERNAL
ts_library( ts_library(
name = "cli", name = "cli",
srcs = [ srcs = [
@ -45,6 +48,7 @@ pkg_npm(
name = "npm_package", name = "npm_package",
srcs = [ srcs = [
"index.bzl", "index.bzl",
"BUILD.bazel",
# Some tools within `dev-infra` which are shipped as Bazel rules might # Some tools within `dev-infra` which are shipped as Bazel rules might
# rely on a tsconfig file. We bring the config into the NPM package. # rely on a tsconfig file. We bring the config into the NPM package.
"tsconfig.json", "tsconfig.json",
@ -55,6 +59,7 @@ pkg_npm(
# angular/angular should not consume it's own packages, so we use # angular/angular should not consume it's own packages, so we use
# substitutions to replace these in the published version of dev-infra. # substitutions to replace these in the published version of dev-infra.
"//dev-infra/": "@npm//@angular/dev-infra-private/", "//dev-infra/": "@npm//@angular/dev-infra-private/",
"//dev-infra:": "@npm//@angular/dev-infra-private:",
"//packages/benchpress": "@npm//@angular/benchpress", "//packages/benchpress": "@npm//@angular/benchpress",
"//packages/bazel": "@npm//@angular/bazel", "//packages/bazel": "@npm//@angular/bazel",
"//packages/zone.js/bundles:zone.umd.js": "@npm//zone.js", "//packages/zone.js/bundles:zone.umd.js": "@npm//zone.js",
@ -106,3 +111,4 @@ ng_dev_rolled_up_generated_file(
"//dev-infra/release/build", "//dev-infra/release/build",
], ],
) )
# END-INTERNAL