honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build(aio): fix warning about missing `<h1>` 

Fixes #17549
This commit is contained in:
Georgios Kalpakas 2017-07-27 01:28:11 +03:00 committed by Alex Rickabaugh
parent a11542a375
commit cc2a4c41f9
3 changed files with 38 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
aio/content/marketing/index.html
View File

@ -14,17 +14,19 @@
<!-- CONTAINER --> <!-- CONTAINER -->
<div class="homepage-container"> <div class="homepage-container">
<!-- container content starts -->
<div class="hero-headline no-toc">One framework.<br>Mobile &amp; desktop.</div> <div class="hero-headline no-toc">One framework.<br>Mobile &amp; desktop.</div>
<a class="button hero-cta" href="guide/quickstart">Get Started</a> <a class="button hero-cta" href="guide/quickstart">Get Started</a>
</div><!-- CONTAINER END --> </div>
</section>
</section>
</header> </header>
<!-- MAIN CONTENT -->
<article> <article>
<h1 class="no-toc" style="display: none"></h1>
<div class="home-rows"> <div class="home-rows">
<!-- Announcement Bar --> <!-- Announcement Bar -->
@ -53,6 +55,7 @@
</div> </div>
</div> </div>
<hr> <hr>
<!-- Group 2 --> <!-- Group 2 -->
<div layout="row" layout-xs="column" class="home-row"> <div layout="row" layout-xs="column" class="home-row">
<div class="text-container"> <div class="text-container">
@ -90,7 +93,6 @@
<!-- Group 4 --> <!-- Group 4 -->
<div layout="row" layout-xs="column" class="home-row"> <div layout="row" layout-xs="column" class="home-row">
<div class="text-container"> <div class="text-container">
<div class="text-block l-pad-top-2"> <div class="text-block l-pad-top-2">
<div class="text-headline">Loved by Millions</div> <div class="text-headline">Loved by Millions</div>
@ -107,7 +109,6 @@
<!-- CTA CARDS --> <!-- CTA CARDS -->
<div layout="row" layout-xs="column" class="home-row"> <div layout="row" layout-xs="column" class="home-row">
<a href="guide/quickstart"> <a href="guide/quickstart">
<div class="card"> <div class="card">
<img src="generated/images/marketing/home/code-icon.svg" height="70px"> <img src="generated/images/marketing/home/code-icon.svg" height="70px">

2
aio/tools/transforms/angular-base-package/post-processors/h1-checker.js vendored
View File

@ -34,5 +34,5 @@ function getText(h1) {
(node.properties.ariaHidden === 'true' || node.properties['aria-hidden'] === 'true') (node.properties.ariaHidden === 'true' || node.properties['aria-hidden'] === 'true')
)); ));
return toString(cleaned); return cleaned ? toString(cleaned) : '';
} }

10
aio/tools/transforms/angular-base-package/post-processors/h1-checker.spec.js
View File

@ -69,4 +69,14 @@ describe('h1Checker postprocessor', () => {
processor.$process([doc]); processor.$process([doc]);
expect(doc.vFile.title).toEqual('What is Angular?'); expect(doc.vFile.title).toEqual('What is Angular?');
}); });
it('should not break if the h1 is empty (except for an aria-hidden anchor)', () => {
const doc = {
docType: 'a',
renderedContent: `
<h1><a aria-hidden="true"></a></h1>
`
};
expect(() => processor.$process([doc])).not.toThrow();
});
}); });