honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(aio): update docs error in guide/http (#23567)

Browse Source 
Updates documentation to include examples for both req.flush and
req.error in http testing examples.

PR Close #23567
This commit is contained in:
Bennett Hardwick 2018-04-27 20:44:07 +10:00 committed by Igor Minar
parent 4cb46ce10c
commit cc6c4346c2
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
aio/content/examples/http/src/testing/http-client.spec.ts
View File

@ -150,7 +150,7 @@ describe('HttpClient testing', () => {
// Create mock ErrorEvent, raised when something goes wrong at the network level. // Create mock ErrorEvent, raised when something goes wrong at the network level.
// Connection timeout, DNS error, offline, etc // Connection timeout, DNS error, offline, etc
const errorEvent = new ErrorEvent('so sad', { const mockError = new ErrorEvent('Network error', {
message: emsg, message: emsg,
// #enddocregion network-error // #enddocregion network-error
// The rest of this is optional and not used. // The rest of this is optional and not used.
@ -162,7 +162,7 @@ describe('HttpClient testing', () => {
}); });
// Respond with mock error // Respond with mock error
req.error(errorEvent); req.error(mockError);
}); });
// #enddocregion network-error // #enddocregion network-error

10
aio/content/guide/http.md
View File

@ -1030,10 +1030,18 @@ you are responsible for flushing and verifying them.
You should test the app's defenses against HTTP requests that fail. You should test the app's defenses against HTTP requests that fail.
Call `request.error()` with an `ErrorEvent` instead of `request.flush()`, as in this example. Call `request.flush()` with an error message, as seen in the following example.
<code-example <code-example
path="http/src/testing/http-client.spec.ts" path="http/src/testing/http-client.spec.ts"
region="404" region="404"
linenums="false"> linenums="false">
</code-example> </code-example>
Alternatively, you can call `request.error()` with an `ErrorEvent`.
<code-example
path="http/src/testing/http-client.spec.ts"
region="network-error"
linenums="false">
</code-example>