honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(localize): ensure that `formatOptions` is optional (#38787) 

Some lower level APIs are used by CLI, and requiring
the `formatOpions` argument at that level is a
breaking change. This commit makes it optional
at every level to avoid the breaking change.

PR Close #38787
This commit is contained in:
Pete Bacon Darwin 2020-09-10 09:17:42 +01:00 committed by Andrew Kushnir
parent d1415162cb
commit ce1efc1af2
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/localize/src/tools/src/extract/main.ts
View File

@ -208,7 +208,7 @@ export function extractTranslations({
export function getSerializer( export function getSerializer(
format: string, sourceLocale: string, rootPath: AbsoluteFsPath, useLegacyIds: boolean, format: string, sourceLocale: string, rootPath: AbsoluteFsPath, useLegacyIds: boolean,
formatOptions: FormatOptions): TranslationSerializer { formatOptions: FormatOptions = {}): TranslationSerializer {
switch (format) { switch (format) {
case 'xlf': case 'xlf':
case 'xlif': case 'xlif':

2
packages/localize/src/tools/src/extract/translation_files/xliff1_translation_serializer.ts
View File

@ -27,7 +27,7 @@ const LEGACY_XLIFF_MESSAGE_LENGTH = 40;
export class Xliff1TranslationSerializer implements TranslationSerializer { export class Xliff1TranslationSerializer implements TranslationSerializer {
constructor( constructor(
private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean, private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean,
private formatOptions: FormatOptions) { private formatOptions: FormatOptions = {}) {
validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions); validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions);
} }

2
packages/localize/src/tools/src/extract/translation_files/xliff2_translation_serializer.ts
View File

@ -27,7 +27,7 @@ export class Xliff2TranslationSerializer implements TranslationSerializer {
private currentPlaceholderId = 0; private currentPlaceholderId = 0;
constructor( constructor(
private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean, private sourceLocale: string, private basePath: AbsoluteFsPath, private useLegacyIds: boolean,
private formatOptions: FormatOptions) { private formatOptions: FormatOptions = {}) {
validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions); validateOptions('Xliff1TranslationSerializer', [['xml:space', ['preserve']]], formatOptions);
} }